wallet: Remove CWalletTx::fTimeReceivedIsTxTime #32768

1. 
   achow101 commented at 9:28 pm on June 17, 2025: member

   CWalletTx::fTimeReceivedIsTxTime is no longer used and can be removed. This additionally allows the removal of the upgraded_txs loop in LoadWallet.
2. 
   DrahtBot commented at 9:28 pm on June 17, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32768.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32763 (wallet: Replace CWalletTx::mapValue and vOrderForm with explicit class members by achow101)
   • #32685 (wallet: Allow read-only database access for info and dump commands by PeterWrighten)
   • #27865 (wallet: Track no-longer-spendable TXOs separately by achow101)
   • #27286 (wallet: Keep track of the wallet’s own transaction outputs in memory by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Wallet on Jun 17, 2025
4. DrahtBot added the label CI failed on Jun 17, 2025
5. achow101 force-pushed on Jun 18, 2025
6. wallet: Remove unused fTimeReceivedIsTxTime

   fTimeReceivedIsTxTime has been unused unused since 0.3.24

   c668033709
7. walletdb: Remove unused upgraded_txs 9eb2c82e7c
8. achow101 force-pushed on Jun 18, 2025
9. DrahtBot removed the label CI failed on Jun 18, 2025

Contributors
achow101 DrahtBot

Labels
Wallet