fuzz: wallet: remove FundTx from FuzzedWallet #32772

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2025-06-fuzz-delete-fundtx changing 1 files +0 −53
  1. brunoerg commented at 7:21 pm on June 18, 2025: contributor
    FundTx was used by the wallet_notifications target which we recently removed. So it’s now unused and can be removed.
  2. fuzz: wallet: remove FundTx from FuzzedWallet cd1ae1b4df
  3. DrahtBot added the label Tests on Jun 18, 2025
  4. DrahtBot commented at 7:21 pm on June 18, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32772.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, dergoegge, kevkevinpal

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32750 (refactor: CFeeRate encapsulates FeeFrac internally by polespinasa)
    • #32618 (wallet: Remove ISMINE_WATCHONLY and watchonly from RPCs by achow101)
    • #32523 (wallet: Remove watchonly behavior and isminetypes by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. brunoerg commented at 7:22 pm on June 18, 2025: contributor
  6. maflcko commented at 7:55 pm on June 18, 2025: member
    lgtm ACK cd1ae1b4dfdb1bb11dec2558448a453f43cb2ac3
  7. dergoegge approved
  8. dergoegge commented at 10:05 am on June 19, 2025: member
    utACK cd1ae1b4dfdb1bb11dec2558448a453f43cb2ac3
  9. kevkevinpal commented at 1:25 pm on June 19, 2025: contributor

    ACK cd1ae1b

    makes sense to remove dead code

  10. fanquake merged this on Jun 19, 2025
  11. fanquake closed this on Jun 19, 2025

  12. brunoerg deleted the branch on Jun 19, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-01 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me