rpc, test: allow multiple data outputs in createrawtransaction & createpsbt #32790

1. 
   yuvicc commented at 12:27 pm on June 21, 2025: contributor

   Since #32406 is merged we can remove the check for multiple data outputs in createrawtransaction and createpsbt rpc.

   Keeping this in draft and review is currently not required as this is in milestone 31.0

   addresses: #32478

2. 
   DrahtBot commented at 12:27 pm on June 21, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32790.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	luke-jr

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

3. 
   Dorex45 commented at 10:41 pm on June 22, 2025: none

   The removal of the duplicate “data” key check simplifies the code path for handling data outputs. However, this means that if multiple “data” fields are present in the outputs object, the last one will silently override any previous entries without raising an error. Was this change intended to allow multiple “data” outputs, or is it assumed that input validation elsewhere will prevent duplicates? If not, could you clarify the motivation behind removing this check? Thanks!
4. maflcko added this to the milestone 31.0 on Jun 23, 2025
5. 
   yuvicc commented at 7:37 am on June 23, 2025: contributor

   If not, could you clarify the motivation behind removing this check? Thanks!

   see #32478, we have policy change merged to remove data outputs size. So this check should be removed from the rpc’s as well!

6. 
   Dorex45 commented at 10:16 am on June 23, 2025: none

   If not, could you clarify the motivation behind removing this check? Thanks!

   see #32478, we have policy change merged to remove data outputs size. So this check should be removed from the rpc’s as well!

   Thanks for the pointer to #32478 , that clears it up! Since multiple data outputs are now valid, would it make sense to reflect that in the RPC help text or release notes for clarity? Also, adding a test with multiple data entries could help future-proof this change. Nice cleanup overall!

7. 
   luke-jr commented at 7:58 pm on June 26, 2025: member

   Concept NACK. Stop trying to enable spam.
8. glozow added the label RPC/REST/ZMQ on Sep 10, 2025
9. maflcko removed this from the milestone 31.0 on Oct 6, 2025
10. 
    mikekelly commented at 10:34 am on October 6, 2025: none

    @yuvicc FYI - there are failing checks on this. If you make this build green then it could be proposed as part of v30 release.
11. 
    mikekelly commented at 10:36 am on October 6, 2025: none

    fwiw - I think if this is going in to 30.0 it would need some kind of warning to tell users that they may face propagation issues. If it’s delayed to 30.1 then a warning probably isn’t necessary.
12. 
    yuvicc commented at 8:04 am on October 16, 2025: contributor

    @mikekelly see the comment, this changes will come in the next release 31.0. Will update this one soon and mark it for review.
13. yuvicc force-pushed on Oct 16, 2025
14. remove check from rawtransaction_util for duplicate data

    test: remove assertions for duplicate data parameter from rpc_rawtransaction & wallet_bumpfee

    0a8324c1f3
15. test: update check for multiple data outputs 80e50ab459
16. yuvicc force-pushed on Nov 3, 2025
17. yuvicc marked this as ready for review on Nov 3, 2025
18. 
    yuvicc commented at 3:58 am on November 4, 2025: contributor

    Ready for review.
19. 
    sedited commented at 12:58 pm on March 19, 2026: contributor

    This did not make the milestone and has not received reviewer attention for some time. I’m not sure, is anybody actually asking for this?

Contributors
yuvicc DrahtBot Dorex45 luke-jr mikekelly sedited

Labels
RPC/REST/ZMQ