rpc, test: allow multiple data outputs in createrawtransaction & createpsbt #32790

1. 
   yuvicc commented at 12:27 pm on June 21, 2025: contributor

   Since #32406 is merged we can remove the check for multiple data outputs in createrawtransaction and createpsbt rpc.

   Keeping this in draft and review is currently not required as this is in milestone 31.0

   addresses: #32478

2. remove check from rawtransaction_util to allow multiple data outputs a3fa5d59ed
3. test: remove assertions for duplicate data parameter bb99e8fa1f
4. 
   DrahtBot commented at 12:27 pm on June 21, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32790.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	luke-jr

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. 
   Dorex45 commented at 10:41 pm on June 22, 2025: none

   The removal of the duplicate “data” key check simplifies the code path for handling data outputs. However, this means that if multiple “data” fields are present in the outputs object, the last one will silently override any previous entries without raising an error. Was this change intended to allow multiple “data” outputs, or is it assumed that input validation elsewhere will prevent duplicates? If not, could you clarify the motivation behind removing this check? Thanks!
6. maflcko added this to the milestone 31.0 on Jun 23, 2025
7. 
   yuvicc commented at 7:37 am on June 23, 2025: contributor

   If not, could you clarify the motivation behind removing this check? Thanks!

   see #32478, we have policy change merged to remove data outputs size. So this check should be removed from the rpc’s as well!

8. 
   Dorex45 commented at 10:16 am on June 23, 2025: none

   If not, could you clarify the motivation behind removing this check? Thanks!

   see #32478, we have policy change merged to remove data outputs size. So this check should be removed from the rpc’s as well!

   Thanks for the pointer to #32478 , that clears it up! Since multiple data outputs are now valid, would it make sense to reflect that in the RPC help text or release notes for clarity? Also, adding a test with multiple data entries could help future-proof this change. Nice cleanup overall!

9. 
   luke-jr commented at 7:58 pm on June 26, 2025: member

   Concept NACK. Stop trying to enable spam.

Contributors
yuvicc DrahtBot Dorex45 luke-jr

Milestone
31.0