Since #32406 is merged we can remove the check for multiple data outputs in createrawtransaction and createpsbt rpc.
Keeping this in draft and review is currently not required as this is in milestone 31.0
addresses: #32478
rpc, test: allow multiple data outputs in `createrawtransaction` & `createpsbt` #32790
pull yuvicc wants to merge 2 commits into bitcoin:master from yuvicc:2025-06-fix-multi-data-outs changing 3 files +3 −12-
yuvicc commented at 12:27 PM on June 21, 2025: contributor
-
DrahtBot commented at 12:27 PM on June 21, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32790.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers Concept NACK luke-jr If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
Dorex45 commented at 10:41 PM on June 22, 2025: none
The removal of the duplicate "data" key check simplifies the code path for handling data outputs. However, this means that if multiple "data" fields are present in the outputs object, the last one will silently override any previous entries without raising an error. Was this change intended to allow multiple "data" outputs, or is it assumed that input validation elsewhere will prevent duplicates? If not, could you clarify the motivation behind removing this check? Thanks!
- maflcko added this to the milestone 31.0 on Jun 23, 2025
-
-
Dorex45 commented at 10:16 AM on June 23, 2025: none
If not, could you clarify the motivation behind removing this check? Thanks!
see #32478, we have policy change merged to remove data outputs size. So this check should be removed from the rpc's as well!
Thanks for the pointer to #32478 , that clears it up! Since multiple data outputs are now valid, would it make sense to reflect that in the RPC help text or release notes for clarity? Also, adding a test with multiple data entries could help future-proof this change. Nice cleanup overall!
-
luke-jr commented at 7:58 PM on June 26, 2025: member
Concept NACK. Stop trying to enable spam.
- glozow added the label RPC/REST/ZMQ on Sep 10, 2025
- maflcko removed this from the milestone 31.0 on Oct 6, 2025
-
-
mikekelly commented at 10:36 AM on October 6, 2025: none
fwiw - I think if this is going in to 30.0 it would need some kind of warning to tell users that they may face propagation issues. If it's delayed to 30.1 then a warning probably isn't necessary.
-
yuvicc commented at 8:04 AM on October 16, 2025: contributor
@mikekelly see the comment, this changes will come in the next release 31.0. Will update this one soon and mark it for review.
- yuvicc force-pushed on Oct 16, 2025
-
0a8324c1f3
remove check from rawtransaction_util for duplicate data
test: remove assertions for duplicate data parameter from rpc_rawtransaction & wallet_bumpfee
-
test: update check for multiple data outputs 80e50ab459
- yuvicc force-pushed on Nov 3, 2025
- yuvicc marked this as ready for review on Nov 3, 2025
-
yuvicc commented at 3:58 AM on November 4, 2025: contributor
Ready for review.
-
sedited commented at 12:58 PM on March 19, 2026: contributor
This did not make the milestone and has not received reviewer attention for some time. I'm not sure, is anybody actually asking for this?
