Fix build on macOS when qt@6 is installed #32804

pull hebasto wants to merge 2 commits into bitcoin:29.x from hebasto:250624-29.x-multi-qt changing 2 files +15 −3
  1. hebasto commented at 4:46 pm on June 24, 2025: member
    Fix #31009 on both arm64 and x64 macOS.
  2. hebasto added the label Build system on Jun 24, 2025
  3. DrahtBot commented at 4:46 pm on June 24, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32804.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. maflcko added this to the milestone 29.1 on Jun 24, 2025
  5. maflcko added the label Needs backport (29.x) on Jun 24, 2025
  6. hebasto commented at 8:06 pm on June 24, 2025: member
    Please review #32805 first.
  7. hebasto commented at 5:54 pm on June 25, 2025: member

    Please review #32805 first.

    Also #32814.

  8. hebasto force-pushed on Jun 25, 2025
  9. cmake: Use `HINTS` instead of `PATHS` in `find_*` commands
    According to the CMake documentation, `HINTS` "should be paths computed
    by system introspection, such as a hint provided by the location of
    another item already found", which is precisely the case in the
    `FindQRencode` module.
    
    Entries in `HINTS` are searched before those in `PATHS`. On macOS,
    Homebrew’s `libqrencode` will therefore be located at its real path
    rather than via the symlink in the default prefix.
    619a6dacb1
  10. cmake: Explicitly specify `Boost_ROOT` for Homebrew's package
    On macOS, this change ensures that the Boost package is located at its
    real path rather than via the symlink in the default prefix.
    812bd51563
  11. hebasto force-pushed on Jun 25, 2025
  12. fanquake referenced this in commit 8fafb81320 on Jun 26, 2025
  13. fanquake commented at 11:12 am on June 26, 2025: member
    Do we need this open? Rebased it’s the same as #32814.
  14. hebasto commented at 12:43 pm on June 26, 2025: member

    Do we need this open? Rebased it’s the same as #32814.

    To make testing this branch easier?

  15. fanquake referenced this in commit 67ea4b9994 on Jun 26, 2025
  16. fanquake removed the label Needs backport (29.x) on Jun 26, 2025
  17. fanquake commented at 2:03 pm on June 26, 2025: member
    Both of these changes are now in #32810, so if someone would like to test them, they can use that branch.
  18. fanquake closed this on Jun 26, 2025

  19. hebasto deleted the branch on Jun 27, 2025


hebasto DrahtBot fanquake

Labels
Build system

Milestone
29.1


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-28 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me