rest: rename strURIPart to uri_part #32825

1. 
   romanz commented at 6:30 am on June 28, 2025: contributor

   Following #32540 (review).
2. DrahtBot added the label RPC/REST/ZMQ on Jun 28, 2025
3. 
   DrahtBot commented at 6:30 am on June 28, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32825.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	l0rinc, maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32791 (checkqueue: implement a new scriptcheck worker pool with atomic variables by HowHsu)
   • #32541 (index: store per-block transaction locations for efficient lookups by romanz)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   maflcko commented at 9:51 am on June 28, 2025: member

   could be a scripted-diff? See e.g. 8888beea8d477b1d4a2dfd2a0bb5f686de62f3ff
5. romanz force-pushed on Jun 28, 2025
6. 
   romanz commented at 11:41 am on June 28, 2025: contributor

   could be a scripted-diff?

   Thanks, TIL :) Fixed in https://github.com/bitcoin/bitcoin/commit/cc2ec2c174c899fd71e3a0205e38077df0e7424f.

7. l0rinc approved
8. 
   l0rinc commented at 11:54 am on June 28, 2025: contributor

   utACK cc2ec2c174c899fd71e3a0205e38077df0e7424f

   nit: it might be slightly simpler in my opinion to inline the function and only do it for a single file instead of all tracked ones:

   0-BEGIN VERIFY SCRIPT-
   1sed -i 's/\<strURIPart\>/uri_part/g' src/rest.cpp
   2-END VERIFY SCRIPT-
   

   nit2: as I’ve seen, the script is usually at the very end of the commit message

9. scripted-diff: rest: rename `strURIPart` -> `uri_part`

   Following https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2172902737.
   
   -BEGIN VERIFY SCRIPT-
   sed -i 's/\<strURIPart\>/uri_part/g' src/rest.cpp
   -END VERIFY SCRIPT-

   856f4235b1
10. romanz force-pushed on Jun 28, 2025
11. 
    romanz commented at 12:00 pm on June 28, 2025: contributor

    Thanks @l0rinc - fixed the nits in https://github.com/bitcoin/bitcoin/commit/856f4235b1ae56540e1d2279c27405d44a5c7b34.

    0$ test/lint/commit-script-check.sh origin/master..HEAD
    1Running script for: 856f4235b1ae56540e1d2279c27405d44a5c7b34
    2sed -i 's/\<strURIPart\>/uri_part/g' src/rest.cpp
    3OK
    

12. 
    l0rinc commented at 12:03 pm on June 28, 2025: contributor

    reACK 856f4235b1ae56540e1d2279c27405d44a5c7b34
13. romanz renamed this:
    rest: rename `strURIPart` -> `uri_part`
    rest: rename `strURIPart` to `uri_part`
    on Jun 28, 2025
14. 
    maflcko commented at 11:05 am on June 30, 2025: member

    lgtm ACK 856f4235b1ae56540e1d2279c27405d44a5c7b34
15. fanquake merged this on Jun 30, 2025
16. fanquake closed this on Jun 30, 2025

    ---

17. romanz deleted the branch on Jun 30, 2025
18. 
    romanz commented at 4:02 pm on June 30, 2025: contributor

    Thanks!

Contributors
romanz DrahtBot maflcko l0rinc

Labels
RPC/REST/ZMQ