Following #32540 (review).
rest: rename `strURIPart` to `uri_part` #32825
pull romanz wants to merge 1 commits into bitcoin:master from romanz:uri-part changing 1 files +20 −20-
romanz commented at 6:30 AM on June 28, 2025: contributor
- DrahtBot added the label RPC/REST/ZMQ on Jun 28, 2025
-
DrahtBot commented at 6:30 AM on June 28, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32825.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #32791 (checkqueue: implement a new scriptcheck worker pool with atomic variables by HowHsu)
- #32541 (index: store per-block transaction locations for efficient lookups by romanz)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 9:51 AM on June 28, 2025: member
could be a scripted-diff? See e.g. 8888beea8d477b1d4a2dfd2a0bb5f686de62f3ff
- romanz force-pushed on Jun 28, 2025
-
romanz commented at 11:41 AM on June 28, 2025: contributor
could be a scripted-diff?
Thanks, TIL :) Fixed in https://github.com/bitcoin/bitcoin/commit/cc2ec2c174c899fd71e3a0205e38077df0e7424f.
- l0rinc approved
-
l0rinc commented at 11:54 AM on June 28, 2025: contributor
utACK cc2ec2c174c899fd71e3a0205e38077df0e7424f
nit: it might be slightly simpler in my opinion to inline the function and only do it for a single file instead of all tracked ones:
-BEGIN VERIFY SCRIPT- sed -i 's/\<strURIPart\>/uri_part/g' src/rest.cpp -END VERIFY SCRIPT-nit2: as I've seen, the script is usually at the very end of the commit message
-
856f4235b1
scripted-diff: rest: rename `strURIPart` -> `uri_part`
Following https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2172902737. -BEGIN VERIFY SCRIPT- sed -i 's/\<strURIPart\>/uri_part/g' src/rest.cpp -END VERIFY SCRIPT-
- romanz force-pushed on Jun 28, 2025
-
romanz commented at 12:00 PM on June 28, 2025: contributor
Thanks @l0rinc - fixed the nits in https://github.com/bitcoin/bitcoin/commit/856f4235b1ae56540e1d2279c27405d44a5c7b34.
$ test/lint/commit-script-check.sh origin/master..HEAD Running script for: 856f4235b1ae56540e1d2279c27405d44a5c7b34 sed -i 's/\<strURIPart\>/uri_part/g' src/rest.cpp OK -
l0rinc commented at 12:03 PM on June 28, 2025: contributor
reACK 856f4235b1ae56540e1d2279c27405d44a5c7b34
- romanz renamed this:
rest: rename `strURIPart` -> `uri_part`
rest: rename `strURIPart` to `uri_part`
on Jun 28, 2025 -
maflcko commented at 11:05 AM on June 30, 2025: member
lgtm ACK 856f4235b1ae56540e1d2279c27405d44a5c7b34
- fanquake merged this on Jun 30, 2025
- fanquake closed this on Jun 30, 2025
- romanz deleted the branch on Jun 30, 2025
-
romanz commented at 4:02 PM on June 30, 2025: contributor
Thanks!
- stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
- alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
- alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
- alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
- yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
- bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
- stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
- Kino1994 referenced this in commit 0b174fb89c on Jun 28, 2026
- BigcoinBGC referenced this in commit ce99245b3e on Jun 30, 2026
- bitcoin locked this on Jul 30, 2026
Labels