Split up bitcoinrpc (code movement only) #3284

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_11_rpc_split changing 18 files +692 −629
  1. laanwj commented at 1:28 PM on November 20, 2013: member

    Split bitcoinrpc up into

    • rpcserver: bitcoind RPC server
    • rpcclient: bitcoin-cli RPC client
    • rpcprotocol: shared common HTTP/JSON-RPC protocol code

    One step towards making bitcoin-cli independent from the rest of the code, and thus a smaller executable that doesn't have to be linked against leveldb.

    This commit only does code movement, there are no functional changes.

  2. laanwj commented at 12:20 PM on November 21, 2013: member

    @sipa @gmaxwell @gavinandresen Can I get some acks here please?

  3. sipa commented at 1:11 PM on November 21, 2013: member

    ACK design. The code looks good, but I haven't checked all moves in detail.

  4. in src/rpcprotocol.cpp:None in 09608542da outdated
       5 | +
       6 | +#include "rpcprotocol.h"
       7 | +
       8 | +#include "util.h"
       9 | +
      10 | +#include <stdint.h>
    


    Diapolo commented at 4:24 PM on November 21, 2013:

    Already included in the header.

  5. super3 commented at 10:23 PM on November 21, 2013: contributor

    ACK concept. Going to take a bit to read through.

  6. Split up bitcoinrpc (code movement only)
    Split bitcoinrpc up into
    
    - rpcserver: bitcoind RPC server
    - rpcclient: bitcoin-cli RPC client
    - rpcprotocol: shared common HTTP/JSON-RPC protocol code
    
    One step towards making bitcoin-cli independent from the rest
    of the code, and thus a smaller executable that doesn't have to
    be linked against leveldb.
    
    This commit only does code movement, there are no functional changes.
    fb78cc2378
  7. BitcoinPullTester commented at 5:49 AM on November 27, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fb78cc23784b2fa478324aac35ca76c7cfe683a4 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  8. laanwj referenced this in commit 5f083afde1 on Nov 27, 2013
  9. laanwj merged this on Nov 27, 2013
  10. laanwj closed this on Nov 27, 2013

  11. laanwj deleted the branch on Apr 9, 2014
  12. Bushstar referenced this in commit 7e85f09007 on Apr 8, 2020
  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me