ci: Use optimized Debug build type in test-each-commit #32888
pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2507-ci-each-commit-debug changing 2 files +9 −3-
maflcko commented at 8:25 am on July 7, 2025: memberAn optimized debug build is mostly as fast as a release build, because hot loops of heavy debug-only code are rare. So use that setting in the test-each-commit CI, to enable more checks almost “for free”.
-
DrahtBot added the label Tests on Jul 7, 2025
-
DrahtBot commented at 8:25 am on July 7, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32888.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK Prabhat1308 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #32865 (cmake: Use
AUTHOR_WARNING
for warnings by fanquake) - #31802 (Add bitcoin-{node,gui} to release binaries for IPC by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- #32865 (cmake: Use
-
ci: [doc] reword debug log message fae1524cdb
-
ci: Use optimized Debug build type in test-each-commit fa21d3c778
-
maflcko force-pushed on Jul 7, 2025
-
Prabhat1308 commented at 12:04 pm on July 7, 2025: contributor
ACK
fa21d3c
changes seem good as discussed in #32829 . Can we use
mold
as a linker in other Linux based system workflows ? dependencies we have seem to satisfy the deps here https://github.com/rui314/mold?tab=readme-ov-file#how-to-build -
maflcko commented at 12:12 pm on July 7, 2025: member
Can we use
mold
as a linker in other Linux based system workflows ?Sure, happy to review a follow-up. Only place to avoid it would probably the ci tasks that mirror the guix build (win-cross, mac-cross)
-
maflcko commented at 2:50 pm on July 7, 2025: memberNo,
-g
isn’t needed for the CI itself. It is only there for developers who happen to run this locally in a container and want to reproduce something in a debugger without having to modify the script and re-compile. Storage is cheap/free, so I thought it can’t hurt to have it, but no strong opinion. Anything should be fine for the setting.
maflcko
DrahtBot
Prabhat1308
theuni
Labels
Tests
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-07 21:13 UTC
More mirrored repositories can be found on mirror.b10c.me