bench: Avoid tmp files in pwd #32890

1. 
   maflcko commented at 11:12 am on July 7, 2025: member

   It is a bit confusing that one bench run, when aborted, could leave behind temp files in the current working directory. It is similarly confusing to delete those files in the next run of bench.

   Fix all issues by using BasicTestingSetup, which provides a proper temp folder to use and also cleans up after itself.

   Can be tested via:

   0( echo 'my file content' > streams_tmp ) && ls streams_tmp && ./bld-cmake/bin/bench_bitcoin --filter=FindByte && ls streams_tmp
   

   Previously the file would be deleted, now it is kept.

2. bench: Avoid tmp files in pwd fa2fbaa4a2
3. DrahtBot added the label Tests on Jul 7, 2025
4. 
   DrahtBot commented at 11:12 am on July 7, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32890.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. stickies-v approved
6. 
   stickies-v commented at 3:19 pm on July 7, 2025: contributor

   ACK fa2fbaa4a29f80d3c7d5f0ad6b64035c3156dd12

   Was able to reproduce both the pre- and post-fixed situation described, and can’t find any other test instances that should be using the testing setup temp dir instead.

Contributors
maflcko DrahtBot stickies-v

Labels
Tests