bench: Avoid tmp files in pwd #32890

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2507-bench-less-clutter changing 1 files +4 −6
  1. maflcko commented at 11:12 AM on July 7, 2025: member

    It is a bit confusing that one bench run, when aborted, could leave behind temp files in the current working directory. It is similarly confusing to delete those files in the next run of bench.

    Fix all issues by using BasicTestingSetup, which provides a proper temp folder to use and also cleans up after itself.

    Can be tested via:

    ( echo 'my file content' > streams_tmp ) && ls streams_tmp && ./bld-cmake/bin/bench_bitcoin --filter=FindByte && ls streams_tmp
    

    Previously the file would be deleted, now it is kept.

  2. bench: Avoid tmp files in pwd fa2fbaa4a2
  3. DrahtBot added the label Tests on Jul 7, 2025
  4. DrahtBot commented at 11:12 AM on July 7, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32890.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK stickies-v

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. stickies-v approved
  6. stickies-v commented at 3:19 PM on July 7, 2025: contributor

    ACK fa2fbaa4a29f80d3c7d5f0ad6b64035c3156dd12

    Was able to reproduce both the pre- and post-fixed situation described, and can't find any other test instances that should be using the testing setup temp dir instead.

  7. fanquake merged this on Jul 10, 2025
  8. fanquake closed this on Jul 10, 2025

  9. maflcko deleted the branch on Jul 10, 2025
  10. stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
  11. alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
  12. alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
  13. alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
  14. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
  15. bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
  16. stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
  17. Kino1994 referenced this in commit 6c76dd3123 on Jun 28, 2026
  18. BigcoinBGC referenced this in commit 5a508cb639 on Jun 30, 2026
  19. bitcoin locked this on Jul 30, 2026
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-04 00:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me