doc: fix BlockConnected incorrect comment #32893

pull ismaelsadeeq wants to merge 1 commits into bitcoin:master from ismaelsadeeq:07-2025-block-connected-comment-fix changing 1 files +0 −1
  1. ismaelsadeeq commented at 5:23 pm on July 7, 2025: member

    This is a simple PR that fixes the BlockConnected validation interface notification comment, which incorrectly states that a vector of transactions removed from the mempool is as a parameter of the method.

    Originally, this was the case when the method was first introduced in #9725

    However, the method has since changed, and this is no longer accurate. Keeping the outdated comment is now misleading.

    This PR removes the information about the method parameters from the docstring, aligning it with the style of other notifications methods. As noticed in this PR, comments listing parameters can become stale and go uncorrected.

    Therefore, this PR simply removes the inaccurate comment without listing the current returned values.

  2. doc: fix `BlockConnected` incorrect comment 4e69aa5701
  3. DrahtBot added the label Docs on Jul 7, 2025
  4. DrahtBot commented at 5:23 pm on July 7, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32893.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK l0rinc

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. l0rinc commented at 7:33 pm on July 7, 2025: contributor

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-07 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me