doc: fix `BlockConnected` incorrect comment #32893

pull ismaelsadeeq wants to merge 1 commits into bitcoin:master from ismaelsadeeq:07-2025-block-connected-comment-fix changing 1 files +0 −1
  1. ismaelsadeeq commented at 5:23 PM on July 7, 2025: member

    This is a simple PR that fixes the BlockConnected validation interface notification comment, which incorrectly states that a vector of transactions removed from the mempool is as a parameter of the method.

    Originally, this was the case when the method was first introduced in #9725

    However, the method has since changed, and this is no longer accurate. Keeping the outdated comment is now misleading.

    This PR removes the information about the method parameters from the docstring, aligning it with the style of other notifications methods. As noticed in this PR, comments listing parameters can become stale and go uncorrected.

    Therefore, this PR simply removes the inaccurate comment without listing the current returned values.

  2. doc: fix `BlockConnected` incorrect comment 4e69aa5701
  3. DrahtBot added the label Docs on Jul 7, 2025
  4. DrahtBot commented at 5:23 PM on July 7, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32893.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK l0rinc, maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. l0rinc commented at 7:33 PM on July 7, 2025: contributor
  6. maflcko commented at 9:28 AM on July 8, 2025: member

    lgtm ACK 4e69aa5701a2dad3805ea26718e6a406adb8b748

  7. fanquake merged this on Jul 8, 2025
  8. fanquake closed this on Jul 8, 2025

  9. ismaelsadeeq deleted the branch on Jul 8, 2025
  10. stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
  11. alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
  12. alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
  13. alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
  14. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
  15. bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
  16. stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
  17. Kino1994 referenced this in commit 047e7e2da7 on Jun 28, 2026
  18. BigcoinBGC referenced this in commit 644272aa54 on Jun 30, 2026
  19. bitcoin locked this on Jul 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-01 15:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me