fuzz: Add missing calls to SetMockTime for determinism #32927

1. 
   maflcko commented at 12:49 pm on July 9, 2025: member

   (Tracking issue #29018)

   During fuzzing, AppInitParameterInteraction may actually disable a previously set mocktime. This is confusing and can also cause non-determinism.

   Fix this issue, by

   • fixing the erroneous -mocktime parsing in AppInitParameterInteraction.
   • adding the missing SetMockTime calls to the affected fuzz init functions.
   • adding a CheckGlobals to the fuzz init, to prevent this issue in the future.

   This can be tested by

   • Cherry-picking the CheckGlobals-commit onto current master and observing a fuzz failure in the touched fuzz targets.
   • Reverting the touched fuzz fixups and observing a fuzz failure for each target.
2. Add SetMockTime for time_point types fa6b45fa8e
3. test: Avoid resetting mocktime in testing setup

   This allows to set the mocktime before the testing setup.
   
   Also, in some fuzz tests the mocktime was reset to 0 before this change,
   so set it.

   fa26bfde98
4. fuzz: CheckGlobals in init fa8862723c
5. DrahtBot added the label Tests on Jul 9, 2025
6. 
   DrahtBot commented at 12:49 pm on July 9, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32927.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	w0xlt, dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32822 (fuzz: Make process_message(s) more deterministic by maflcko)
   • #32430 (test: Add and use ElapseTime helper by maflcko)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. fanquake requested review from dergoegge on Jul 10, 2025
8. fanquake requested review from marcofleon on Jul 10, 2025
9. 
   w0xlt commented at 8:45 pm on July 10, 2025: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/32927/commits/fa8862723c14cdd471bbffc7a4897ece2e6d8a7f
10. dergoegge approved
11. 
    dergoegge commented at 9:40 am on July 11, 2025: member

    utACK fa8862723c14cdd471bbffc7a4897ece2e6d8a7f
12. fanquake merged this on Jul 11, 2025
13. fanquake closed this on Jul 11, 2025

    ---

14. 
    marcofleon commented at 11:07 am on July 11, 2025: contributor

    post merge ACK fa8862723c14cdd471bbffc7a4897ece2e6d8a7f
15. maflcko deleted the branch on Jul 11, 2025
16. stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
17. alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
18. alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
19. alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
20. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
21. bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
22. fanquake added the label Fuzzing on Oct 30, 2025

Contributors
maflcko DrahtBot w0xlt dergoegge marcofleon

Labels
Tests Fuzzing