Enable `-Werror=dev` in CI & Guix

fanquake commented at 11:06 am on July 10, 2025: member

Pass -Werror=dev in the CI, Guix and the dev-mode preset.

https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-Werror:

Make developer warnings errors. Make warnings that are meant for the author of the CMakeLists.txt files errors. By default this will also turn on deprecated warnings as errors.

Pulled out of #32865.

cmake: enable -Werror=dev in dev-mode preset 435798cb64

guix: configure with -Werror=dev c6afc53dc7

ci: enable -Werror=dev

Turn developer & deprecation warnings into errors.

35e0331493

DrahtBot commented at 11:06 am on July 10, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32937.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#32888 (ci: Use optimized Debug build type in test-each-commit by maflcko)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto commented at 11:13 am on July 10, 2025: member

Concept ACK.

fanquake commented at 1:36 pm on July 10, 2025: member

Guix Build:

 0c7870f6c402ac407d0de4edc21d42f5040d19374deaba50b496e4f99a421c8e8  guix-build-35e0331493e9/output/aarch64-linux-gnu/SHA256SUMS.part
 1d64532e1bd83568f2386a6b67c49e0843f08c0d486828b1cd0ce955a179b07bb  guix-build-35e0331493e9/output/aarch64-linux-gnu/bitcoin-35e0331493e9-aarch64-linux-gnu-debug.tar.gz
 2a158a955bf7b82ef1572db4ad5fd4d5b2885631cad810102b67d16eaadb4e3df  guix-build-35e0331493e9/output/aarch64-linux-gnu/bitcoin-35e0331493e9-aarch64-linux-gnu.tar.gz
 3225421a4d478e602bf97cda523491cb88d2094d3d79cc6e6f714268f22744642  guix-build-35e0331493e9/output/arm-linux-gnueabihf/SHA256SUMS.part
 43ce4e0580f4376f795b2517b6d2b1485ae79c88720399428f0d7fb091b225f10  guix-build-35e0331493e9/output/arm-linux-gnueabihf/bitcoin-35e0331493e9-arm-linux-gnueabihf-debug.tar.gz
 5c740ecedc658e6efe6f9db177da29b280331a7d04782c5507b6db84fb8746721  guix-build-35e0331493e9/output/arm-linux-gnueabihf/bitcoin-35e0331493e9-arm-linux-gnueabihf.tar.gz
 6b867a1f066177978cbd62e5dbe4ff0a61f55e3dfd54ea15db6331ed0aa7e790d  guix-build-35e0331493e9/output/arm64-apple-darwin/SHA256SUMS.part
 7951f02919625c100dfd170a24c22587d8e69fa201fdf90f49435920b118ad03a  guix-build-35e0331493e9/output/arm64-apple-darwin/bitcoin-35e0331493e9-arm64-apple-darwin-codesigning.tar.gz
 84e86d8a96acace32cfeca1efcd3859b619067aeed232487a50bb6a36e73d35ff  guix-build-35e0331493e9/output/arm64-apple-darwin/bitcoin-35e0331493e9-arm64-apple-darwin-unsigned.tar.gz
 9cb2787563cd5a52ab8d1845f31de2cbe409e4e5b22d735c8a924a0b3257fe851  guix-build-35e0331493e9/output/arm64-apple-darwin/bitcoin-35e0331493e9-arm64-apple-darwin-unsigned.zip
105932610ac08d5319a2f7eacac50a6006f5ddd1298e7e9a03ad11a3d47c2ed2d9  guix-build-35e0331493e9/output/dist-archive/bitcoin-35e0331493e9.tar.gz
1128ab5b3ecc26bfbc35449b554a91ce3efa8eaeffa7a527a5dc1d96ff64b092b6  guix-build-35e0331493e9/output/powerpc64-linux-gnu/SHA256SUMS.part
1252a450747b1346b1261dfbfb7d28b6b4c50ac7654664b828d5210cdb875d3db7  guix-build-35e0331493e9/output/powerpc64-linux-gnu/bitcoin-35e0331493e9-powerpc64-linux-gnu-debug.tar.gz
138d74cb299984b216ec9cce2c6a49fd58366f54854cf24dd19060dd92fa271be3  guix-build-35e0331493e9/output/powerpc64-linux-gnu/bitcoin-35e0331493e9-powerpc64-linux-gnu.tar.gz
1495fc7f05ef5fefe4faa1d00c1ed65ba7e2bbf55ed0b5956856df6059bff37329  guix-build-35e0331493e9/output/riscv64-linux-gnu/SHA256SUMS.part
156b66ea4a194e753372c45a5f2cc44297a838a14be749732d63da8a59c535d4fb  guix-build-35e0331493e9/output/riscv64-linux-gnu/bitcoin-35e0331493e9-riscv64-linux-gnu-debug.tar.gz
160067036b78d320ec826f7cdd561fc86f80f2ad6357289b00e1fa72e629e993ea  guix-build-35e0331493e9/output/riscv64-linux-gnu/bitcoin-35e0331493e9-riscv64-linux-gnu.tar.gz
1794f16aa167169bf027ad3c0a1735c0b9f59adac175cab154bb1250661754b7e1  guix-build-35e0331493e9/output/x86_64-apple-darwin/SHA256SUMS.part
180df06a64baf859599b7ae483053d6fb08d8cf02b132551f302849bffe04c7ad9  guix-build-35e0331493e9/output/x86_64-apple-darwin/bitcoin-35e0331493e9-x86_64-apple-darwin-codesigning.tar.gz
19e71e98a89c1847ad6ae3b0bde23695786629f5a204da37bb4e8826ba8909ddc7  guix-build-35e0331493e9/output/x86_64-apple-darwin/bitcoin-35e0331493e9-x86_64-apple-darwin-unsigned.tar.gz
203f524d75271b5232182c169e708f46f1c3934c5cebd25ac002cf95e927760da9  guix-build-35e0331493e9/output/x86_64-apple-darwin/bitcoin-35e0331493e9-x86_64-apple-darwin-unsigned.zip
2102cf5b7ee85a6b8e54889a2e39f1f334c138aa86a96f1721171eda4ea2cfd172  guix-build-35e0331493e9/output/x86_64-linux-gnu/SHA256SUMS.part
2298aa219e4e5c010f78916dc05dc9a95bf2480b06c6dce1601bea8009ebaf518a  guix-build-35e0331493e9/output/x86_64-linux-gnu/bitcoin-35e0331493e9-x86_64-linux-gnu-debug.tar.gz
23610e38e87a9887feebb1ab7ff93cd86815778a8ec94d01162752d3e2ae744634  guix-build-35e0331493e9/output/x86_64-linux-gnu/bitcoin-35e0331493e9-x86_64-linux-gnu.tar.gz
24a6e0e71d413b1bcca7b10791c9ac65e15a3f05e738ae640d14119f805286e66a  guix-build-35e0331493e9/output/x86_64-w64-mingw32/SHA256SUMS.part
251a0bf35394105b87be623cd6ad242e47218248d087132e7f3b17e1161790f1ba  guix-build-35e0331493e9/output/x86_64-w64-mingw32/bitcoin-35e0331493e9-win64-codesigning.tar.gz
261769813048d6b8987158423ae64d6efb9c5f23832d3502784cf6f87c1091603d  guix-build-35e0331493e9/output/x86_64-w64-mingw32/bitcoin-35e0331493e9-win64-debug.zip
275aa7dc1aee191e60fe6c356293f234804d2ed60260dd14d423c0a80670ad052d  guix-build-35e0331493e9/output/x86_64-w64-mingw32/bitcoin-35e0331493e9-win64-setup-unsigned.exe
2870964cc3471d6c47e446cb8ef4e40b2a975c902af5af87ca02c16e29fcbb3449  guix-build-35e0331493e9/output/x86_64-w64-mingw32/bitcoin-35e0331493e9-win64-unsigned.zip

Enable -Werror=dev in CI & Guix #32937

Code Coverage & Benchmarks

Reviews

Conflicts

Enable `-Werror=dev` in CI & Guix #32937