depends: Force CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE #32943

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250710-package-registry changing 1 files +1 −0
  1. hebasto commented at 7:20 pm on July 10, 2025: member

    When using CMake policies 3.14 and below, the export(PACKAGE) command by default populates the user package registry, which is stored outside the build tree. Setting the CMAKE_EXPORT_NO_PACKAGE_REGISTRY variable disables this side effect.

    In CMake 3.15 and later, this behavior is disabled by default, and the variable has no effect.

    This PR forces CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE globally, rather than managing it for each dependency package individually rather. It may be reverted once all CMake-based packages have updated to policies 3.15 or newer.

    Fixes #32938.

  2. depends: Force `CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE`
    When using CMake policies 3.14 and below, the `export(PACKAGE)` command
    by default populates the user package registry, which is stored outside
    the build tree. Setting the `CMAKE_EXPORT_NO_PACKAGE_REGISTRY` variable
    disables this side effect.
    
    In CMake 3.15 and later, this behavior is disabled by default, and the
    variable has no effect.
    44f3bae300
  3. hebasto added the label Build system on Jul 10, 2025
  4. DrahtBot commented at 7:20 pm on July 10, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32943.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK theuni

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. theuni commented at 9:54 pm on July 10, 2025: member

    Yikes. Concept ACK.

    Could we also set CMAKE_FIND_USE_PACKAGE_REGISTRY to false in the toolchain file as a belt-and-suspenders in case some future package manually opts-in using CMAKE_EXPORT_PACKAGE_REGISTRY ?


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-11 03:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me