This adds tests for the -blockreconstructionextratxn parameter which controls the extra transaction pool used for compact block reconstruction.
Uses RBF transaction pairs to populate the pool since that’s a straightforward way to get transactions into the extra pool - send an original, then replace it with higher fee, and the original ends up in the extra pool.
This adds comprehensive functional tests for the extra transaction pool
used in compact block reconstruction, controlled by the
-blockreconstructionextratxn parameter.
The tests verify:
- Pool capacity limits and FIFO eviction behavior
- Disabled pool behavior when set to 0
- Edge cases with single capacity and wraparound
- Invalid parameter handling
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33023.
See the guideline for information on the review process. A summary of reviews will appear here.
🚧 At least one of the CI tasks failed.
Task lint: https://github.com/bitcoin/bitcoin/runs/46342861746
LLM reason (✨ experimental): The CI failure is primarily caused by lint errors detected by ruff, including issues with trailing whitespace and possible spelling errors.
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
