[29.x] test: Do not pass tests on unhandled exceptions #33046

pull fanquake wants to merge 3 commits into bitcoin:29.x from fanquake:29_x_unhandled_exceptions changing 2 files +4 −15
  1. fanquake commented at 4:03 pm on July 23, 2025: member
    Backports #33001 to 29.x.
  2. test: Do not pass tests on unhandled exceptions
    This adds a missing catch for BaseException (e.g. SystemExit), which
    would otherwise be silently ignored.
    
    Also, remove the redundant other catches, which are just calling
    log.exception with a redundant log message.
    
    Github-Pull: #33001
    Rebased-From: fa30b34026f76a5b8af997152fced2d281782e0d
    79e1a3c9c6
  3. test: Log KeyboardInterrupt as exception
    log.exception is more verbose and useful to debug timeouts.
    
    Also, log stderr for CalledProcessError to make debugging easier.
    
    Github-Pull: #33001
    Rebased-From: faa3e684118bffa7a98cf76eeeb59243219df900
    5e327e6703
  4. doc: update release notes for 29.x 411e15194b
  5. fanquake added this to the milestone 29.1 on Jul 23, 2025
  6. DrahtBot added the label Backport on Jul 23, 2025
  7. DrahtBot commented at 4:03 pm on July 23, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33046.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK pablomartin4btc, marcofleon

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  8. pablomartin4btc approved
  9. pablomartin4btc commented at 4:09 pm on July 23, 2025: member
    ACK 411e15194b3a770ff455d413a0fe2495f0362297
  10. fanquake requested review from marcofleon on Jul 24, 2025
  11. marcofleon commented at 10:51 am on July 24, 2025: contributor
    lgtm ACK 411e15194b3a770ff455d413a0fe2495f0362297
  12. fanquake merged this on Jul 24, 2025
  13. fanquake closed this on Jul 24, 2025

  14. fanquake deleted the branch on Jul 24, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-02 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me