Is there a specific reason not to validate the address in the sendtoaddress RPC?
This PR adds that.
wallet: Add address validation in `sendtoaddress` RPC #33068
pull w0xlt wants to merge 1 commits into bitcoin:master from w0xlt:sendtoaddress_validation changing 2 files +13 −0-
w0xlt commented at 4:35 AM on July 26, 2025: contributor
- DrahtBot added the label Wallet on Jul 26, 2025
-
DrahtBot commented at 4:35 AM on July 26, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33068.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
wallet: Add address validation in `sendtoaddress` RPC bbfd55762f
- w0xlt force-pushed on Jul 26, 2025
- DrahtBot added the label CI failed on Jul 26, 2025
-
DrahtBot commented at 4:41 AM on July 26, 2025: contributor
<!--85328a0da195eb286784d51f73fa0af9-->
🚧 At least one of the CI tasks failed. <sub>Task
previous releases, depends DEBUG: https://github.com/bitcoin/bitcoin/runs/46770879558</sub> <sub>LLM reason (✨ experimental): The CI failed due to a syntax error in spend.cpp caused by a missing semicolon before a closing brace.</sub><details><summary>Hints</summary>
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
</details>
- w0xlt closed this on Jul 26, 2025