tsan: drop DEBUG_LOCKORDER macro from TSAN job? #33087

issue fanquake openend this issue on July 29, 2025
  1. fanquake commented at 9:23 am on July 29, 2025: member

    It was pointed out in #32862 (comment) that that PR uncovered a false positive libc++ tsan warning. It was not initially clear to me why the issue was not happening in the TSAN CI. The reason it does not, is because of DEBUG_LOCKORDER. Dropping that from the TSAN CI job does shows the issue. i.e #33081.

    I am wondering if the TSAN job should be split up, so that TSAN & DEBUG_LOCKORDER do not interfere with each other. It seems better to not have false positives (or real issues/anything else) in other tooling suppressed, by our own tooling, and instead be able to directly suppress/document issues, and properly report them upstream.

  2. fanquake added the label Brainstorming on Jul 29, 2025
  3. fanquake closed this on Jul 31, 2025

  4. fanquake referenced this in commit aef2dbb402 on Jul 31, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-03 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me