ci: Remove unused CI_FAILFAST_TEST_LEAVE_DANGLING #33137

pull maflcko wants to merge 4 commits into bitcoin:master from maflcko:2508-ci-less-settings changing 5 files +6 −7
  1. maflcko commented at 1:00 pm on August 5, 2025: member

    CI_FAILFAST_TEST_LEAVE_DANGLING was added in commit 26d98d51f2cfc902df35f855590c052e16a5ce12 to run a bash trap. However, now that the trap was removed in commit 904631e0fc00ac9c8a03d1ce226d071bf88c00db, this can be removed as well.

    If there is need for this in the future, it seems simpler to just explicitly execute test_runner.py in a new session via setsid instead of using this config/env juggling.

  2. ci: Remove unused CI_FAILFAST_TEST_LEAVE_DANGLING fadfb4642f
  3. DrahtBot added the label Tests on Aug 5, 2025
  4. DrahtBot commented at 1:01 pm on August 5, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33137.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32989 (ci: Migrate CI to hosted Cirrus Runners by willcl-ark)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. maflcko commented at 1:45 pm on August 5, 2025: member

    Induced failure works and looks as expected: https://github.com/bitcoin/bitcoin/runs/47420378191 (Just adding a new Exit status: 137 at the end)

    edit: actually macOS is timing out: https://github.com/bitcoin/bitcoin/actions/runs/16750826059/job/47420350768

  6. maflcko force-pushed on Aug 5, 2025
  7. DrahtBot added the label CI failed on Aug 5, 2025
  8. TEST NO MERGE WIP TRIGGER BUG 63f99d8e66
  9. setsid 140c1286b1
  10. maflcko force-pushed on Aug 5, 2025
  11. bla 530c6d49ae
  12. maflcko force-pushed on Aug 5, 2025
  13. maflcko commented at 4:51 pm on August 5, 2025: member
    No idea why neither kill nor setsid works on macos, but both work on Linux. I guess this means CI_FAILFAST_TEST_LEAVE_DANGLING is still needed.
  14. maflcko closed this on Aug 5, 2025

  15. maflcko deleted the branch on Aug 5, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-12 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me