ci: Pass CI_FAILFAST_TEST_LEAVE_DANGLING into container #33138

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2508-ci-pass-dangling changing 1 files +6 −3
  1. maflcko commented at 5:04 pm on August 5, 2025: member

    After commit fd813bf863b1ffa91429de6342285b35bab2bfa4, the env var CI_FAILFAST_TEST_LEAVE_DANGLING is no longer passed into the container.

    This is harmless, because it isn’t needed for the Linux containers and macos doesn’t use containers at all.

    However, it would be nice to document it as an allowed setting and consistently pass it on, when set. So do that here.

  2. ci: Pass CI_FAILFAST_TEST_LEAVE_DANGLING into container fa1d2f6380
  3. DrahtBot added the label Tests on Aug 5, 2025
  4. DrahtBot commented at 5:04 pm on August 5, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33138.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. fanquake commented at 9:30 am on August 6, 2025: member
    ACK fa1d2f63803e71d21b470cf4eb52fbe941aa0b28
  6. fanquake merged this on Aug 6, 2025
  7. fanquake closed this on Aug 6, 2025

  8. maflcko deleted the branch on Aug 6, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-12 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me