macdeploy: avoid use of Bitcoin Core in Linux cross build #33158

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:linux_cross_use_distname_host changing 3 files +16 −15
  1. fanquake commented at 4:26 pm on August 8, 2025: member
    Output bitcoin-macos-app.zip, similar to what we do for Windows: bitcoin-win64-setup.exe. Bitcoin-Core.zip is retained for native macOS deploys.
  2. DrahtBot commented at 4:26 pm on August 8, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33158.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK jonatack, hodlinator

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    No conflicts as of last run.

  3. jonatack commented at 4:42 pm on August 8, 2025: member
    Concept ACK
  4. hodlinator commented at 11:00 pm on August 9, 2025: contributor
    Concept ACK
  5. macdeploy: combine appname & -zip arguments
    appname is only used by -zip.
    9231bd055a
  6. macdeploy: remove hard-coded Bitcoin Core from Guix build
    We were naming this "Bitcoin-Core.zip", just to immediately rename it.
    Similar to what we do with Windows, i.e `bitcoin-win64-setup.exe`.
    59ecf91018
  7. fanquake force-pushed on Aug 11, 2025
  8. achow101 commented at 6:13 pm on August 12, 2025: member

    ~0

    I find it weird that we would produce files named differently for the same target when the hosts are different. Is there a reason that the zip should include the software name in its name anyways?


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-13 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me