bitcoin-macos-app.zip
, similar to what we do for Windows: bitcoin-win64-setup.exe
.
Bitcoin-Core.zip
is retained for native macOS deploys.
Bitcoin Core
in Linux cross build
#33158
bitcoin-macos-app.zip
, similar to what we do for Windows: bitcoin-win64-setup.exe
.
Bitcoin-Core.zip
is retained for native macOS deploys.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33158.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
Concept ACK | jonatack, hodlinator |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
No conflicts as of last run.
appname is only used by -zip.
We were naming this "Bitcoin-Core.zip", just to immediately rename it.
Similar to what we do with Windows, i.e `bitcoin-win64-setup.exe`.
~0
I find it weird that we would produce files named differently for the same target when the hosts are different. Is there a reason that the zip should include the software name in its name anyways?