BIP360: Includes the following: #33163

pull jbride wants to merge 1 commits into bitcoin:master from jbride:p2qrh changing 26 files +691 −22
  1. jbride commented at 6:43 pm on August 9, 2025: none
    1. validateaddress RPC now support p2qrh address
    2. ability to spend from a p2qrh utxo
    3. p2qrh related integration tests
    4. deriveaddresses and getdescriptorinfo RPC functions now support qrh() descriptor

    TO-DO:

    1. change all references of P2QRH to P2TSH
    2. version 2 witness program (instead of version 3)
    3. remove “quantum root” functionality and leverage P2TR merkle root
    4. P2TSH specific unit tests
  2. BIP360: Includes the following:
    1.  validateaddress RPC now support p2qrh address
    2.  ability to spend from a p2qrh utxo
    3.  p2qrh related integration tests
    4.  deriveaddresses and getdescriptorinfo RPC functions now support
        qrh() descriptor
    e8eac40cc0
  3. DrahtBot commented at 6:43 pm on August 9, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33163.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32998 (Bump SCRIPT_VERIFY flags to 64 bit by ajtowns)
    • #32966 (Silent Payments: Receiving by Eunovo)
    • #32861 (Have createwalletdescriptor auto-detect an unused(KEY) by Sjors)
    • #32784 (wallet: derivehdkey RPC to get xpub at arbitrary path by Sjors)
    • #32729 (test,refactor: extract script template helpers & widen sigop count coverage by l0rinc)
    • #32652 (wallet: add codex32 argument to addhdkey by roconnor-blockstream)
    • #31989 (BIP-119 (OP_CHECKTEMPLATEVERIFY) (regtest only) by jamesob)
    • #30243 (descriptors: taproot partial descriptors by Eunovo)
    • #29247 (CAT in Tapscript (BIP-347) by arminsabouri)
    • #29136 (wallet: addhdkey RPC to add just keys to wallets via new unused(KEY) descriptor by achow101)
    • #28201 (Silent Payments: sending by josibake)
    • #28122 (Silent Payments: Implement BIP352 by josibake)
    • #27260 (Enhanced error messages for invalid network prefix during address parsing. by portlandhodl)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label CI failed on Aug 9, 2025
  5. DrahtBot commented at 7:40 pm on August 9, 2025: contributor

    🚧 At least one of the CI tasks failed. Task lint: https://github.com/bitcoin/bitcoin/runs/47740932800 LLM reason (✨ experimental): The CI failure is caused by a trailing whitespace error detected during the lint check.

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  6. pinheadmz commented at 10:45 pm on August 9, 2025: member
    Is this a 700-line consensus change in a single commit with no activation code?
  7. glozow added the label Consensus on Aug 11, 2025
  8. glozow added the label Needs Conceptual Review on Aug 11, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-12 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me