KnapsackSolver missing doc comments #33168

issue yancyribbens openend this issue on August 10, 2025
  1. yancyribbens commented at 11:10 am on August 10, 2025: contributor
    The KnapsackSolver is missing helpful doc comments about its usage. Like CoinGrinder and BnB, it would be helpful if the solver explained it’s usage, under what condition it’s useful. description of parameters etc.
  2. furszy commented at 3:39 pm on August 10, 2025: member
    Feel free to document it. Once all KnapsackSolver edge scenarios are properly described, we can consider deprecating it in favor of more targeted algorithms.
  3. yancyribbens commented at 5:59 pm on August 10, 2025: contributor

    Feel free to document it. Once all KnapsackSolver edge scenarios are properly described, we can consider deprecating it in favor of more targeted algorithms.

    Alright. I’ll probably start with SRD which also needs docs..

  4. fanquake commented at 8:11 am on August 12, 2025: member
    If you are just going to do this, then it seems like any (further) discussion can just happen in the PR adding the docs. Closing this for now.
  5. fanquake closed this on Aug 12, 2025

  6. fanquake added the label Docs on Aug 12, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-13 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me