The KnapsackSolver is missing helpful doc comments about its usage. Like CoinGrinder and BnB, it would be helpful if the solver explained it's usage, under what condition it's useful. description of parameters etc.
-
yancyribbens commented at 11:10 AM on August 10, 2025: contributor
-
furszy commented at 3:39 PM on August 10, 2025: member
Feel free to document it. Once all KnapsackSolver edge scenarios are properly described, we can consider deprecating it in favor of more targeted algorithms.
-
yancyribbens commented at 5:59 PM on August 10, 2025: contributor
Feel free to document it. Once all KnapsackSolver edge scenarios are properly described, we can consider deprecating it in favor of more targeted algorithms.
Alright. I'll probably start with
SRDwhich also needs docs.. -
fanquake commented at 8:11 AM on August 12, 2025: member
If you are just going to do this, then it seems like any (further) discussion can just happen in the PR adding the docs. Closing this for now.
- fanquake closed this on Aug 12, 2025
- fanquake added the label Docs on Aug 12, 2025
Contributors
Labels