Using file(GLOB) in the generates step is discouraged because the globbing result may be out of date when the target is built. Performing the globbing in a script that is executed as the build target means the result is always reproducable and the overhead of globbing is only paid when used.
As a follow up, the dependency on sed may be removed by performing the replacement with cmake. Also, the logic from extract_strings_qt.py can be migrated to cmake.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33200.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hebasto |
| Concept ACK | TheCharlatan |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Concept ACK.
Thank you!
0@@ -0,0 +1,82 @@
1+# Copyright (c) 2012-2025 The Bitcoin Core developers
7+ COPYRIGHT_HOLDERS
8+ LCONVERT_EXECUTABLE
9+ LUPDATE_EXECUTABLE
10+ PYTHON_EXECUTABLE
11+ XGETTEXT_EXECUTABLE
12+ )
style-nit: Everywhere else, closing parentheses are aligned with the beginning of the command:
0)
Define Everywhere?
This project codebase.
40+ EXCLUDE REGEX "${PROJECT_SOURCE_DIR}/src/${directory}/.*"
41+ )
42+endforeach()
43+
44+set(ENV{XGETTEXT} "${XGETTEXT_EXECUTABLE}")
45+set(ENV{COPYRIGHT_HOLDERS} "${COPYRIGHT_HOLDERS}")
extract_strings_qt.py only.
57+ -I ${PROJECT_SOURCE_DIR}/src
58+ -locations relative ${PROJECT_SOURCE_DIR}/src/qt/bitcoinstrings.cpp
59+ ${ui_files}
60+ ${qt_translatable_sources}
61+ -ts ${PROJECT_SOURCE_DIR}/src/qt/locale/bitcoin_en.ts
62+ WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
WORKING_DIRECTORY option needed here and below?
Using `file(GLOB)` in the generates step is discouraged because the
globbing result may be out of date when the target is built.
Performing the globbing in a script that is executed as the build
target means the result is always reproducable and the overhead
of globbing is only paid when used.
As a follow up, the dependency on `sed` may be removed by performing
the replacement with cmake. Also, the logic from extract_strings_qt.py
can be migrated to cmake.
