mini miner: enable Linearize return package feerates #33216

1. 
   ismaelsadeeq commented at 5:07 pm on August 19, 2025: member

   This PR adds supports for mini miner to return the package fee rates of the linearized transactions

   The first step for #30079

   It is motivated by #30079 (comment)

2. 
   DrahtBot commented at 5:07 pm on August 19, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33216.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30079 (Fee Estimation: Ignore all transactions that are CPFP’d by ismaelsadeeq)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. in src/node/mini_miner.h:24 in ed6752ce35 outdated

   20@@ -21,6 +21,16 @@ class CTxMemPool;
   21 
   22 namespace node {
   23 
   24+struct LinearizationResult {
   

   ---

   ---

   

   optout21 commented at 9:04 am on September 2, 2025:

   nit: Add a comment on the struct?

   ---

   

   ismaelsadeeq commented at 7:50 pm on September 2, 2025:

   I think the variable name is descriptive enough hence no need for a comment.
4. in src/node/mini_miner.h:171 in ed6752ce35 outdated

   167@@ -161,11 +168,10 @@ class MiniMiner
   168      * if it cannot be calculated. */
   169     std::optional<CAmount> CalculateTotalBumpFees(const CFeeRate& target_feerate);
   170 
   171-    /** Construct a new block template with all of the transactions and calculate the order in which
   172-     * they are selected. Returns the sequence number (lower = selected earlier) with which each
   173-     * transaction was selected, indexed by txid, or an empty map if it cannot be calculated.
   174+    /** Construct a new block template with all of the transactions and calculate both the order in
   

   ---

   ---

   

   optout21 commented at 9:06 am on September 2, 2025:

   nit: Consider removing ‘both’: it is prone to going stale with future change and it adds not much information

   ---

   

   ismaelsadeeq commented at 8:11 pm on September 2, 2025:

   Done.
5. glozow added the label Utils/log/libs on Sep 2, 2025
6. mini miner: enable `Linearize` return package feerates

   Co-authored-by: willcl-ark <will@256k1.dev>

   c24b183ffa
7. ismaelsadeeq force-pushed on Sep 2, 2025
8. 
   optout21 commented at 8:11 pm on September 3, 2025: none

   This PR only extends the return data with the package fee rate, but it does not use the new data. Is a follow-up PR available (as draft) where the new data is used?
9. 
   ismaelsadeeq commented at 9:07 am on September 4, 2025: member

   Yes it is used in #30079

Contributors
ismaelsadeeq DrahtBot optout21

Labels
Utils/log/libs