mini miner: enable `Linearize` return package feerates #33216

pull ismaelsadeeq wants to merge 1 commits into bitcoin:master from ismaelsadeeq:08-2025-mini-miner-return-packages changing 3 files +24 −16

ismaelsadeeq commented at 5:07 PM on August 19, 2025: member

This PR adds supports for mini miner to return the package fee rates of the linearized transactions

The first step for #30079

It is motivated by #30079 (comment)
DrahtBot commented at 5:07 PM on August 19, 2025: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33216.



Reviews

See the guideline for information on the review process.

Type Reviewers

Concept ACK murchandamus

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #30079 (Fee Estimation: Ignore all transactions that are CPFP'd by ismaelsadeeq)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in src/node/mini_miner.h:24 in ed6752ce35 outdated
```
  20 | @@ -21,6 +21,16 @@ class CTxMemPool;
  21 |  
  22 |  namespace node {
  23 |  
  24 | +struct LinearizationResult {
```
optout21 commented at 9:04 AM on September 2, 2025:

nit: Add a comment on the struct?

ismaelsadeeq commented at 7:50 PM on September 2, 2025:

I think the variable name is descriptive enough hence no need for a comment.

Type	Reviewers
Concept ACK	murchandamus

in src/node/mini_miner.h:171 in ed6752ce35 outdated

 167 | @@ -161,11 +168,10 @@ class MiniMiner
 168 |       * if it cannot be calculated. */
 169 |      std::optional<CAmount> CalculateTotalBumpFees(const CFeeRate& target_feerate);
 170 |  
 171 | -    /** Construct a new block template with all of the transactions and calculate the order in which
 172 | -     * they are selected. Returns the sequence number (lower = selected earlier) with which each
 173 | -     * transaction was selected, indexed by txid, or an empty map if it cannot be calculated.
 174 | +    /** Construct a new block template with all of the transactions and calculate both the order in

optout21 commented at 9:06 AM on September 2, 2025:

nit: Consider removing 'both': it is prone to going stale with future change and it adds not much information

ismaelsadeeq commented at 8:11 PM on September 2, 2025:

Done.

glozow added the label Utils/log/libs on Sep 2, 2025
mini miner: enable `Linearize` return package feerates
Co-authored-by: willcl-ark <will@256k1.dev>
c24b183ffa
ismaelsadeeq force-pushed on Sep 2, 2025
optout21 commented at 8:11 PM on September 3, 2025: none

This PR only extends the return data with the package fee rate, but it does not use the new data. Is a follow-up PR available (as draft) where the new data is used?
ismaelsadeeq commented at 9:07 AM on September 4, 2025: member

Yes it is used in #30079
murchandamus commented at 1:02 PM on November 3, 2025: contributor

Concept ACK
ismaelsadeeq closed this on Nov 26, 2025

Contributors

Labels

Linked (view graph)

#30079 Fee Estimation: Ignore all transactions that are CPFP'd

mini miner: enable `Linearize` return package feerates #33216

Code Coverage & Benchmarks

Reviews

Conflicts