depends: `native_libmultiprocess` fails to build on OpenBSD #33219

hebasto commented at 6:00 PM on August 19, 2025: member

The native_libmultiprocess package fails to build on OpenBSD starting with #32345:

$ uname -a
OpenBSD openbsd.home 7.7 GENERIC.MP#625 amd64
$ gmake -j 1 -C depends/ MULTIPROCESS=1 native_libmultiprocess
gmake: Entering directory '/home/hebasto/dev/bitcoin/depends'
Extracting native_libmultiprocess...
(SHA256) /home/hebasto/dev/bitcoin/depends/sources/src-ipc-libmultiprocess.tar: OK
Preprocessing native_libmultiprocess...
Configuring native_libmultiprocess...
-- The CXX compiler identification is Clang 16.0.6
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Performing Test HAVE_PTHREAD_GETNAME_NP
-- Performing Test HAVE_PTHREAD_GETNAME_NP - Failed
-- Performing Test HAVE_PTHREAD_THREADID_NP
-- Performing Test HAVE_PTHREAD_THREADID_NP - Failed
-- Performing Test HAVE_PTHREAD_GETTHREADID_NP
-- Performing Test HAVE_PTHREAD_GETTHREADID_NP - Failed
-- Configuring done (1.6s)
-- Generating done (0.3s)
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY


-- Build files have been written to: /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-openbsd7.7/native_libmultiprocess/-874c5f6e479
Building native_libmultiprocess...
gmake[1]: Entering directory '/home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-openbsd7.7/native_libmultiprocess/-874c5f6e479'
[ 14%] Building CXX object CMakeFiles/mputil.dir/src/mp/util.cpp.o
[ 14%] Built target mputil
[ 28%] Compiling Cap'n Proto schema include/mp/proxy.capnp
[ 42%] Building CXX object CMakeFiles/multiprocess.dir/include/mp/proxy.capnp.c++.o
[ 57%] Building CXX object CMakeFiles/multiprocess.dir/src/mp/proxy.cpp.o
[ 71%] Linking CXX static library libmultiprocess.a
[ 71%] Built target multiprocess
[ 85%] Building CXX object CMakeFiles/mpgen.dir/src/mp/gen.cpp.o
[100%] Linking CXX executable mpgen
ld: warning: string.c++(string.c++.o:(kj::_::(anonymous namespace)::FloatToBuffer(float, char*)) in archive /home/hebasto/dev/bitcoin/depends/x86_64-unknown-openbsd7.7/native/lib/libkj.a): warning: strcpy() is almost always misused, please use strlcpy()
ld: warning: parser.c++(parser.c++.o:(capnp::compiler::CapnpParser::CapnpParser(capnp::Orphanage, capnp::compiler::ErrorReporter&)::$_39::operator()(capnp::compiler::(anonymous namespace)::Located<capnp::Text::Reader>&&, kj::Maybe<capnp::Orphan<capnp::compiler::LocatedInteger>>&&, capnp::compiler::(anonymous namespace)::Located<kj::Array<kj::Maybe<capnp::compiler::(anonymous namespace)::Located<capnp::Text::Reader>>>>&&, capnp::Orphan<capnp::compiler::Expression>&&, kj::Array<capnp::Orphan<capnp::compiler::Declaration::AnnotationApplication>>&&) const) in archive /home/hebasto/dev/bitcoin/depends/x86_64-unknown-openbsd7.7/native/lib/libcapnpc.a): warning: strcat() is almost always misused, please use strlcat()
ld: error: undefined hidden symbol: std::__1::basic_ostream<char, std::__1::char_traits<char>>& std::__1::operator<<[abi:v160006]<char, std::__1::char_traits<char>>(std::__1::basic_ostream<char, std::__1::char_traits<char>>&, std::__1::__thread_id)
>>> referenced by util.cpp
>>>               CMakeFiles/mputil.dir/src/mp/util.cpp.o:(mp::ThreadName(char const*))
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [CMakeFiles/mpgen.dir/build.make:110: mpgen] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:1138: CMakeFiles/mpgen.dir/all] Error 2
gmake[1]: *** [Makefile:146: all] Error 2
gmake[1]: Leaving directory '/home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-openbsd7.7/native_libmultiprocess/-874c5f6e479'
gmake: *** [funcs.mk:345: /home/hebasto/dev/bitcoin/depends/work/build/x86_64-unknown-openbsd7.7/native_libmultiprocess/-874c5f6e479/./.stamp_built] Error 2
gmake: Leaving directory '/home/hebasto/dev/bitcoin/depends'

hebasto added the label Build system on Aug 19, 2025

hebasto commented at 6:02 PM on August 19, 2025: member

cc @ryanofsky

Sjors commented at 6:06 PM on August 19, 2025: member

@vasild if I remember correctly you had a PR to add ?BSD CI coverage?

hebasto commented at 6:08 PM on August 19, 2025: member

@vasild if I remember correctly you had a PR to add ?BSD CI coverage?

For Bitcoin Core, see https://github.com/hebasto/bitcoin-core-nightly.

Sjors commented at 6:14 PM on August 19, 2025: member

Maybe we could have a label like "moar-ci" that runs these extra systems? Similar to how we can request guix builds.

ryanofsky commented at 6:48 PM on August 19, 2025: contributor

I am waiting for openbsd to slowly install in a vm. It might not be too hard to add an openbsd job in the libmultiprocess repository too with https://github.com/vmactions/openbsd-vm

ryanofsky commented at 9:34 PM on August 19, 2025: contributor

Thanks for the report and clear reproduction steps. Following change fixes the problem for me, and I guess this was caused by the IWYU commit in https://github.com/bitcoin-core/libmultiprocess/pull/184,

--- a/src/ipc/libmultiprocess/src/mp/util.cpp
+++ b/src/ipc/libmultiprocess/src/mp/util.cpp
@@ -16,6 +16,7 @@
 #include <sys/socket.h>
 #include <sys/wait.h>
 #include <system_error>
+#include <thread>
 #include <unistd.h>
 #include <utility>
 #include <vector>

An alternate change also fixed the problem:

--- a/src/ipc/libmultiprocess/src/mp/util.cpp
+++ b/src/ipc/libmultiprocess/src/mp/util.cpp
@@ -69,7 +69,7 @@ std::string ThreadName(const char* exe_name)
 #elif defined(HAVE_PTHREAD_GETTHREADID_NP)
     buffer << pthread_getthreadid_np();
 #else
-    buffer << std::this_thread::get_id();
+    buffer << pthread_self();
 #endif
 
     return std::move(buffer).str();

But the first change is probably better.

maflcko referenced this in commit 51073c3d38 on Aug 21, 2025

maflcko referenced this in commit dd40897efe on Aug 21, 2025

maflcko added this to the milestone 30.0 on Aug 21, 2025

maflcko commented at 3:22 PM on August 21, 2025: member

upstream fix (from the previous comment) is at https://github.com/bitcoin-core/libmultiprocess/pull/195

ryanofsky referenced this in commit f1fad396bf on Aug 22, 2025

achow101 referenced this in commit 6ca6f3b37b on Aug 25, 2025

maflcko commented at 7:57 AM on August 26, 2025: member

Closing for now as "fixed"

maflcko closed this on Aug 26, 2025