ci: cd into BASE_BUILD_DIR for GetCMakeLogFiles #33291

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2025/08/cd changing 1 files +1 −0

Sjors commented at 12:24 PM on September 3, 2025: member

When a bug is introduced in cmake, we render its logs, which was broken: #33290 (comment)
ci: cd into BASE_BUILD_DIR for GetCMakeLogFiles 9b76eef2d2
DrahtBot added the label Tests on Sep 3, 2025
DrahtBot commented at 12:24 PM on September 3, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33291.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Type	Reviewers
ACK	maflcko, hebasto

maflcko commented at 12:34 PM on September 3, 2025: member

I haven't checked, but it seems plausible that I introduced this bug in commit fad191ff48b15832a90c19d560a7c0525c146be3, which fixed two other bugs.

Regardless, it seems better to specify the dir explicitly, than to silently/implicitly depend on it.

lgtm ACK 9b76eef2d2b42703e2a30952d4c3474b533e360a 💽

<details><summary>Show signature</summary>

Signature:

untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: lgtm ACK 9b76eef2d2b42703e2a30952d4c3474b533e360a 💽
9VPCcFb8LcL7ClVCll/K/RAxkQIs36XR8Gebz7YMpmNvwY8ArmIDMkYrqVTC8BoOSzoXM2ah+ca2njQbCSTqBw==

</details>

maflcko requested review from hebasto on Sep 3, 2025
hebasto approved
hebasto commented at 3:07 PM on September 4, 2025: member

ACK 9b76eef2d2b42703e2a30952d4c3474b533e360a, obviously.
hebasto merged this on Sep 4, 2025
hebasto closed this on Sep 4, 2025

Contributors

Labels

Linked (view graph)

#33290 build: suggest -DENABLE_IPC=OFF when missing capnp

ci: cd into BASE_BUILD_DIR for GetCMakeLogFiles #33291

Code Coverage & Benchmarks

Reviews