Mentioned by @mzumsande here: #31663 (comment)
I see unconditional log messages [net:warning] pcp: Could not receive response: Connection refused (111) every 5 minutes (in an environment where PCP is expected to not work), and it’s a bit spammy. How about a exponential backoff, similar to how it’s done in torcontrol.cpp?
How about a exponential backoff, similar to how it’s done in torcontrol.cpp?
That was just a random association, I don’t know enough about PCP specifics to judge if it makes much sense. Other questions would be:
net - how actionable is the warning? (it seems to occur for multiple people)
Is it worth trying every 5 minutes forever instead of giving up after a number of tries? Maybe just log unconditionally once but still try ever 5 minutes?
Yes, imo it is. And i don’t think exponential backoff would be good here, either. If the user switches to a network with a PCP-supporting router, we want to use that as soon as possible.
But moving the noisy failure messages to a category makes sense, imo. If someone wants to debug PCP issues they can enable that category.
