ci: disable cirrus cache in 32bit arm job #33302

1. 
   willcl-ark commented at 9:17 am on September 4, 2025: member

   Add an optional matrix field allowing opt-out of configuring cirrus GHA cache when not using cirrus runners.

   This is not needed for the cirruslabs/[save|restore]-cache actions, as they automatically fallback based on runner type.

   Addresses #31965 (comment)

2. DrahtBot added the label Tests on Sep 4, 2025
3. 
   DrahtBot commented at 9:17 am on September 4, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33302.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. in .github/workflows/ci.yml:510 in 593672fbc9 outdated

   506@@ -506,7 +507,7 @@ jobs:
   507       - name: Configure Docker
   508         uses: ./.github/actions/configure-docker
   509         with:
   510-          use-cirrus: ${{ needs.runners.outputs.use-cirrus-runners }}
   511+          use-cirrus: ${{ matrix.use-cirrus != null && matrix.use-cirrus || needs.runners.outputs.use-cirrus-runners }}
   

   ---

   ---

   

   maflcko commented at 9:41 am on September 4, 2025:

   ?

   any || true, will just be true, no?

   Also, the error looks the same, so this has no effect?

5. m3dwards force-pushed on Sep 4, 2025
6. in .github/workflows/ci.yml:510 in 4520e96a76 outdated

   506@@ -506,7 +507,7 @@ jobs:
   507       - name: Configure Docker
   508         uses: ./.github/actions/configure-docker
   509         with:
   510-          use-cirrus: ${{ needs.runners.outputs.use-cirrus-runners }}
   511+          use-cirrus: ${{ matrix.use-cirrus != null && matrix.use-cirrus || matrix.use-cirrus == null && needs.runners.outputs.use-cirrus-runners }}
   

   ---

   ---

   

   maflcko commented at 4:01 pm on September 4, 2025:

   hmm, still wrong https://github.com/bitcoin/bitcoin/actions/runs/17469260337/job/49613109539?pr=33302#step:5:7 ?

   ---

   

   willcl-ark commented at 6:51 pm on September 4, 2025:

   OK I think this push got it: https://github.com/bitcoin/bitcoin/actions/runs/17473683984/job/49628131536?pr=33302#step:5:339
7. 
   maflcko commented at 4:01 pm on September 4, 2025: member

   also, looks like a cache outage in another task?
8. willcl-ark force-pushed on Sep 4, 2025
9. 
   fanquake commented at 3:44 pm on September 8, 2025: member

   cc @m3dwards
10. in .github/workflows/ci.yml:430 in 0263c2db1a outdated

    426@@ -427,6 +427,7 @@ jobs:
    427       matrix:
    428         include:
    429           - name: '32 bit ARM, unit tests, no functional tests'
    430+            use-cirrus: 'false' # As we use GH runners here, manually opt-out of trying to use a cirrus-hosted docker cache.
    

    ---

    ---

    

    m3dwards commented at 6:05 pm on September 8, 2025:

    This works but I do feel a little icky about using a truthy string value of ‘false’. I realise this gets passed to bash which doesn’t have types but it is used in gha expression which does have concept of truthy. It took me a second to understand how false || true resulted in false and then I clocked it was a string.

    Do you think it’s too invasive to perhaps change the input from a boolean “use-cirrus” to a string “cache-provider” with values of “cirrus” and “gha”?

    ---

    

    willcl-ark commented at 9:40 am on September 11, 2025:

    Done in ff18b6bbaf3.

    LMK what you think of the new approach. I agree it’s clearer.

    ---

    

    willcl-ark commented at 9:41 am on September 11, 2025:

    Run on my fork at: https://github.com/willcl-ark/bitcoin/actions/runs/17626151823
11. willcl-ark force-pushed on Sep 10, 2025
12. ci: refactor docker action to return provider str

    Avoid relying on future truthy evaluations of string 'false'.

    ff18b6bbaf
13. ci: disable cirrus cache in 32bit arm job

    Co-authored-by: Max Edwards <youwontforgetthis@gmail.com>
    Add an optional matrix field allowing opt-out of configuring cirrus
    GHA cache when not using cirrus runners.
    
    This is not needed for the cirruslabs/[save|restore]-cache actions, as
    they automatically fallback based on runner type.

    00c253d494
14. willcl-ark force-pushed on Sep 10, 2025
15. fanquake added the label Needs backport (30.x) on Sep 11, 2025

Contributors
willcl-ark DrahtBot maflcko fanquake m3dwards

Labels
Tests Needs backport (30.x)