depends: strip when installing qt binaries #33304

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:strip_qt_bins changing 2 files +2 −2
  1. fanquake commented at 12:51 pm on September 4, 2025: member
    Otherwise we end up with ~1.5GB of binaries (Linux) when DEBUG=1. This isn’t great generally, but is worse in the CI, where disk may be limited (#33293).
  2. depends: strip when installing qt 
    Otherwise we end up with ~1.5GB of binaries (Linux) when DEBUG=1..
    c9d5f211c1
  3. DrahtBot added the label Build system on Sep 4, 2025
  4. DrahtBot commented at 12:51 pm on September 4, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33304.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. TheCharlatan approved
  6. TheCharlatan commented at 2:22 pm on September 4, 2025: contributor
    ACK c9d5f211c119268d776af282dfd1e8b7590aaf56
  7. fanquake added the label DrahtBot Guix build requested on Sep 4, 2025
  8. fanquake commented at 3:16 pm on September 4, 2025: member

    Guix Build (aarch64):

     0c805e4ee4a80b3b03919d280a32f272426811470646aca1e3da0a60255347738  guix-build-c9d5f211c119/output/aarch64-linux-gnu/SHA256SUMS.part
 158f02ff3f18cd39e9379d0896680c9f7b6a3544a02362bb98570b95131f9d8cf  guix-build-c9d5f211c119/output/aarch64-linux-gnu/bitcoin-c9d5f211c119-aarch64-linux-gnu-debug.tar.gz
 25432eaaacb722bb998c2fe76e56e62ef728f60bc7fb27d50dd9ca08dc4648c09  guix-build-c9d5f211c119/output/aarch64-linux-gnu/bitcoin-c9d5f211c119-aarch64-linux-gnu.tar.gz
 3997f4c68aa61864b934e7a9b361a846493cceff54351c6605059997f9f356975  guix-build-c9d5f211c119/output/arm-linux-gnueabihf/SHA256SUMS.part
 4cb57a0d85d01a8fe4362dd98962966cef79e3f830473c8b5a7be4990f2804ea9  guix-build-c9d5f211c119/output/arm-linux-gnueabihf/bitcoin-c9d5f211c119-arm-linux-gnueabihf-debug.tar.gz
 585f231b330ccebebba42daf0ad823903236e53c3d98cb089c3c9d949a85f29e3  guix-build-c9d5f211c119/output/arm-linux-gnueabihf/bitcoin-c9d5f211c119-arm-linux-gnueabihf.tar.gz
 64032e9246253abbb4d5f39dee7e6565613a6abd59696100b4c39e92bb1b905b7  guix-build-c9d5f211c119/output/arm64-apple-darwin/SHA256SUMS.part
 77cc929ae14e4df1aa235eb21a7f5a052ce70b1bc4a9b7599e8609ce27f405131  guix-build-c9d5f211c119/output/arm64-apple-darwin/bitcoin-c9d5f211c119-arm64-apple-darwin-codesigning.tar.gz
 888da7adf0d2ebb183ba0851515735f2ad76d285de8f82698887f9bc36e96c35b  guix-build-c9d5f211c119/output/arm64-apple-darwin/bitcoin-c9d5f211c119-arm64-apple-darwin-unsigned.tar.gz
 9304aa9d7935c2678f89e324e71dcc045886623841a872901e6b177e30e897ed6  guix-build-c9d5f211c119/output/arm64-apple-darwin/bitcoin-c9d5f211c119-arm64-apple-darwin-unsigned.zip
1049831840ab31abc090d3040aa4e4ad182a9529538cf8dbb4489fd0db7a5eb219  guix-build-c9d5f211c119/output/dist-archive/bitcoin-c9d5f211c119.tar.gz
11bfff2228351e76d3e6cdad25c9abf00be0d5a03b98e562860121d9c01f5799ac  guix-build-c9d5f211c119/output/powerpc64-linux-gnu/SHA256SUMS.part
12ff8fb77574bf1bfabbaba296a3df4f86aafed1cf887066ff3263646e1a306a24  guix-build-c9d5f211c119/output/powerpc64-linux-gnu/bitcoin-c9d5f211c119-powerpc64-linux-gnu-debug.tar.gz
13392ba688ca3ac325f3edaed535e17d1f0b6c390b928d3a71f5022d64a2b7cefc  guix-build-c9d5f211c119/output/powerpc64-linux-gnu/bitcoin-c9d5f211c119-powerpc64-linux-gnu.tar.gz
14c18de71661b68b54bd6d7d90d150a3a269a89587d0c4135183bc79fc6f0f3ba1  guix-build-c9d5f211c119/output/riscv64-linux-gnu/SHA256SUMS.part
150dc284d407f8fa438cdcc5986da26bcf61a9c0bf101046ccb1b5dc4aae4c4033  guix-build-c9d5f211c119/output/riscv64-linux-gnu/bitcoin-c9d5f211c119-riscv64-linux-gnu-debug.tar.gz
16c4e30ad6d557cbfe75790a97b2b6d1ca5b5567c2f9a14e78027b7146535c928c  guix-build-c9d5f211c119/output/riscv64-linux-gnu/bitcoin-c9d5f211c119-riscv64-linux-gnu.tar.gz
17d7706248fe15f94e3dc4b21b9f2d29c120cbe40cbd26d98c69f08da72aea0157  guix-build-c9d5f211c119/output/x86_64-apple-darwin/SHA256SUMS.part
1862defa3be4d6414574c16163e77407ac7daaa31d3c50e909eddda14eeb538c8b  guix-build-c9d5f211c119/output/x86_64-apple-darwin/bitcoin-c9d5f211c119-x86_64-apple-darwin-codesigning.tar.gz
191ae594244f1b016df4fc3cbec68bfa2a225861c2d33793f9b04d1ad96ed4a662  guix-build-c9d5f211c119/output/x86_64-apple-darwin/bitcoin-c9d5f211c119-x86_64-apple-darwin-unsigned.tar.gz
204e2c6c38bc90cc2519b35af183dfed48c7dd1dd29fd92bfe2010cb350d440790  guix-build-c9d5f211c119/output/x86_64-apple-darwin/bitcoin-c9d5f211c119-x86_64-apple-darwin-unsigned.zip
2112d662b7198b0986907003067bf3bafc9e1c3d0f9555c545c8e363950db32522  guix-build-c9d5f211c119/output/x86_64-linux-gnu/SHA256SUMS.part
2220a09169ab9ddc95a62a6e68a274c132340b80ca178a615e26d3782a4996c53f  guix-build-c9d5f211c119/output/x86_64-linux-gnu/bitcoin-c9d5f211c119-x86_64-linux-gnu-debug.tar.gz
2320b101363aef1904806f9ca97419b4e73ab196502461ffe09cd99d58a9e08d5f  guix-build-c9d5f211c119/output/x86_64-linux-gnu/bitcoin-c9d5f211c119-x86_64-linux-gnu.tar.gz
24b825d2d3ea77c4adc649a7b7272fda55d08745fd0d0f53e8ccd006974871f5b8  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/SHA256SUMS.part
25328965b409984681bf66a3e6a789f43bb9b65f19ce3f186a33693cf4dc945106  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/bitcoin-c9d5f211c119-win64-codesigning.tar.gz
26534293c36a8a8c14ff4c7566c164341434ae26c28121cc1bc0ddb97546f4c816  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/bitcoin-c9d5f211c119-win64-debug.zip
27d51f5a298538a1c50acb68be76d990b33b125f9ee765f7115e66143d073e22ff  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/bitcoin-c9d5f211c119-win64-setup-unsigned.exe
28f155330784c3d1190f1b2748a87599b1a6e55a72784aeeb29e42829f61555de8  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/bitcoin-c9d5f211c119-win64-unsigned.zip
  9. hebasto commented at 6:24 pm on September 4, 2025: member

    My Guix build:

     0x86_64
 1c805e4ee4a80b3b03919d280a32f272426811470646aca1e3da0a60255347738  guix-build-c9d5f211c119/output/aarch64-linux-gnu/SHA256SUMS.part
 258f02ff3f18cd39e9379d0896680c9f7b6a3544a02362bb98570b95131f9d8cf  guix-build-c9d5f211c119/output/aarch64-linux-gnu/bitcoin-c9d5f211c119-aarch64-linux-gnu-debug.tar.gz
 35432eaaacb722bb998c2fe76e56e62ef728f60bc7fb27d50dd9ca08dc4648c09  guix-build-c9d5f211c119/output/aarch64-linux-gnu/bitcoin-c9d5f211c119-aarch64-linux-gnu.tar.gz
 4997f4c68aa61864b934e7a9b361a846493cceff54351c6605059997f9f356975  guix-build-c9d5f211c119/output/arm-linux-gnueabihf/SHA256SUMS.part
 5cb57a0d85d01a8fe4362dd98962966cef79e3f830473c8b5a7be4990f2804ea9  guix-build-c9d5f211c119/output/arm-linux-gnueabihf/bitcoin-c9d5f211c119-arm-linux-gnueabihf-debug.tar.gz
 685f231b330ccebebba42daf0ad823903236e53c3d98cb089c3c9d949a85f29e3  guix-build-c9d5f211c119/output/arm-linux-gnueabihf/bitcoin-c9d5f211c119-arm-linux-gnueabihf.tar.gz
 74032e9246253abbb4d5f39dee7e6565613a6abd59696100b4c39e92bb1b905b7  guix-build-c9d5f211c119/output/arm64-apple-darwin/SHA256SUMS.part
 87cc929ae14e4df1aa235eb21a7f5a052ce70b1bc4a9b7599e8609ce27f405131  guix-build-c9d5f211c119/output/arm64-apple-darwin/bitcoin-c9d5f211c119-arm64-apple-darwin-codesigning.tar.gz
 988da7adf0d2ebb183ba0851515735f2ad76d285de8f82698887f9bc36e96c35b  guix-build-c9d5f211c119/output/arm64-apple-darwin/bitcoin-c9d5f211c119-arm64-apple-darwin-unsigned.tar.gz
10304aa9d7935c2678f89e324e71dcc045886623841a872901e6b177e30e897ed6  guix-build-c9d5f211c119/output/arm64-apple-darwin/bitcoin-c9d5f211c119-arm64-apple-darwin-unsigned.zip
1149831840ab31abc090d3040aa4e4ad182a9529538cf8dbb4489fd0db7a5eb219  guix-build-c9d5f211c119/output/dist-archive/bitcoin-c9d5f211c119.tar.gz
12bfff2228351e76d3e6cdad25c9abf00be0d5a03b98e562860121d9c01f5799ac  guix-build-c9d5f211c119/output/powerpc64-linux-gnu/SHA256SUMS.part
13ff8fb77574bf1bfabbaba296a3df4f86aafed1cf887066ff3263646e1a306a24  guix-build-c9d5f211c119/output/powerpc64-linux-gnu/bitcoin-c9d5f211c119-powerpc64-linux-gnu-debug.tar.gz
14392ba688ca3ac325f3edaed535e17d1f0b6c390b928d3a71f5022d64a2b7cefc  guix-build-c9d5f211c119/output/powerpc64-linux-gnu/bitcoin-c9d5f211c119-powerpc64-linux-gnu.tar.gz
15c18de71661b68b54bd6d7d90d150a3a269a89587d0c4135183bc79fc6f0f3ba1  guix-build-c9d5f211c119/output/riscv64-linux-gnu/SHA256SUMS.part
160dc284d407f8fa438cdcc5986da26bcf61a9c0bf101046ccb1b5dc4aae4c4033  guix-build-c9d5f211c119/output/riscv64-linux-gnu/bitcoin-c9d5f211c119-riscv64-linux-gnu-debug.tar.gz
17c4e30ad6d557cbfe75790a97b2b6d1ca5b5567c2f9a14e78027b7146535c928c  guix-build-c9d5f211c119/output/riscv64-linux-gnu/bitcoin-c9d5f211c119-riscv64-linux-gnu.tar.gz
18d7706248fe15f94e3dc4b21b9f2d29c120cbe40cbd26d98c69f08da72aea0157  guix-build-c9d5f211c119/output/x86_64-apple-darwin/SHA256SUMS.part
1962defa3be4d6414574c16163e77407ac7daaa31d3c50e909eddda14eeb538c8b  guix-build-c9d5f211c119/output/x86_64-apple-darwin/bitcoin-c9d5f211c119-x86_64-apple-darwin-codesigning.tar.gz
201ae594244f1b016df4fc3cbec68bfa2a225861c2d33793f9b04d1ad96ed4a662  guix-build-c9d5f211c119/output/x86_64-apple-darwin/bitcoin-c9d5f211c119-x86_64-apple-darwin-unsigned.tar.gz
214e2c6c38bc90cc2519b35af183dfed48c7dd1dd29fd92bfe2010cb350d440790  guix-build-c9d5f211c119/output/x86_64-apple-darwin/bitcoin-c9d5f211c119-x86_64-apple-darwin-unsigned.zip
2212d662b7198b0986907003067bf3bafc9e1c3d0f9555c545c8e363950db32522  guix-build-c9d5f211c119/output/x86_64-linux-gnu/SHA256SUMS.part
2320a09169ab9ddc95a62a6e68a274c132340b80ca178a615e26d3782a4996c53f  guix-build-c9d5f211c119/output/x86_64-linux-gnu/bitcoin-c9d5f211c119-x86_64-linux-gnu-debug.tar.gz
2420b101363aef1904806f9ca97419b4e73ab196502461ffe09cd99d58a9e08d5f  guix-build-c9d5f211c119/output/x86_64-linux-gnu/bitcoin-c9d5f211c119-x86_64-linux-gnu.tar.gz
25b825d2d3ea77c4adc649a7b7272fda55d08745fd0d0f53e8ccd006974871f5b8  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/SHA256SUMS.part
26328965b409984681bf66a3e6a789f43bb9b65f19ce3f186a33693cf4dc945106  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/bitcoin-c9d5f211c119-win64-codesigning.tar.gz
27534293c36a8a8c14ff4c7566c164341434ae26c28121cc1bc0ddb97546f4c816  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/bitcoin-c9d5f211c119-win64-debug.zip
28d51f5a298538a1c50acb68be76d990b33b125f9ee765f7115e66143d073e22ff  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/bitcoin-c9d5f211c119-win64-setup-unsigned.exe
29f155330784c3d1190f1b2748a87599b1a6e55a72784aeeb29e42829f61555de8  guix-build-c9d5f211c119/output/x86_64-w64-mingw32/bitcoin-c9d5f211c119-win64-unsigned.zip
  10. hebasto approved
  11. hebasto commented at 6:26 pm on September 4, 2025: member
    ACK c9d5f211c119268d776af282dfd1e8b7590aaf56.
  12. fanquake merged this on Sep 5, 2025
  13. fanquake closed this on Sep 5, 2025
  14. fanquake deleted the branch on Sep 5, 2025
  15. fanquake commented at 9:46 am on September 5, 2025: member

    Before this change, depends built cache restore for the centos DEBUG=1 job:

    0Cache hit for restore-key: depends-built-ci_native_centos-b5ec5a84074477732c9e7415e49fda779e2e820d1953a68b1654b7dc77d6eedd
1
2Cache Size: ~1090 MB (1143026710 B)

    The depends built cache saved after this PR:

    0Sent 524648857 of 591757721 (88.7%), 38.5 MBs/sec
1Sent 591757721 of 591757721 (100.0%), 40.3 MBs/sec
2Cache saved with key: depends-built-ci_native_centos-0e079181cbaa95598b2653530a556fb95c55e35f4fd53165df76c790f4431fa5

    So looks like this has saved ~500mb from the saved cache size.

  16. DrahtBot commented at 3:53 pm on September 5, 2025: contributor

    Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

    File commit e1ce0c525c7f70311640ed39f4b8f4cbad1d79c8(master) commit dfd2fc00b601757ee2f9d611bfbac576a19df2e7(pull/33304/merge)
    *-aarch64-linux-gnu-debug.tar.gz 6afc24d12d455e62... d4d5fbac77e77a8a...
    *-aarch64-linux-gnu.tar.gz 677160c8b6d6157a... 4d99870bf257d0f2...
    *-arm-linux-gnueabihf-debug.tar.gz d141f06f5f64e177... 7d8f2db145502b38...
    *-arm-linux-gnueabihf.tar.gz 5d96f63e94db1653... 5f953752b3e98e54...
    *-arm64-apple-darwin-codesigning.tar.gz 16a6b4320d0e38d4... f0e938f604b45d7b...
    *-arm64-apple-darwin-unsigned.tar.gz a3e3215931b47dc4... cfa2aafc6cf0b893...
    *-arm64-apple-darwin-unsigned.zip ebc81453d3be7ecb... 98be84d4b356db76...
    *-powerpc64-linux-gnu-debug.tar.gz 3bbdf4d575a0bfa9... f3b4c9f8fa6445fd...
    *-powerpc64-linux-gnu.tar.gz 20448b73ad1cfa1e... da0ed19d354d9591...
    *-riscv64-linux-gnu-debug.tar.gz 5cdffd5e07a9ad4a... cbacf4f2049dd8aa...
    *-riscv64-linux-gnu.tar.gz 2cd0f5aaf4efba27... 1c27dfbd14ad4404...
    *-x86_64-apple-darwin-codesigning.tar.gz d775d6e93167bb4b... f437588eba2cd4d4...
    *-x86_64-apple-darwin-unsigned.tar.gz df710be51f7b271c... 204bad405dd09a64...
    *-x86_64-apple-darwin-unsigned.zip 6b0d61bb9ea2bb02... fe2491d4c1117b9a...
    *-x86_64-linux-gnu-debug.tar.gz fb9a8f9fe330e6fd... e011bb12f8c52fa4...
    *-x86_64-linux-gnu.tar.gz 631bee5afffb943b... 8ca1d0bc2f3596ca...
    *.tar.gz 40bf4049741c5dc6... 637da0a89afb0e91...
    SHA256SUMS.part 680d9e80b6263ab9... 2077006226a68ea2...
    guix_build.log 79a7b59a70b985a8... 78e072f6a209dc2a...
    guix_build.log.diff e30d2099c3f99910...
  17. DrahtBot removed the label DrahtBot Guix build requested on Sep 5, 2025


fanquake DrahtBot TheCharlatan hebasto

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-10 18:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me