doc: fix LIBRARY_PATH comment #33308

1. 
   fanquake commented at 4:33 pm on September 4, 2025: member

   Now that we build capnp, qt isn’t the only native package.
2. doc: fix LIBRARY_PATH comment

   Now that we build capnp, qt isn't the only native package.

   a2a35b58cb
3. DrahtBot added the label Docs on Sep 4, 2025
4. 
   DrahtBot commented at 4:33 pm on September 4, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33308.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	l0rinc, willcl-ark

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32764 (guix: Build for macOS using Clang only by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. l0rinc approved
6. 
   l0rinc commented at 7:00 pm on September 4, 2025: contributor

   code review ACK a2a35b58cb957b7fba113eb4cf933d5e7b9bf8ef
7. willcl-ark approved
8. 
   willcl-ark commented at 7:25 pm on September 4, 2025: member

   ACK a2a35b58cb957b7fba113eb4cf933d5e7b9bf8ef
9. in contrib/guix/libexec/build.sh:77 in a2a35b58cb

   73@@ -74,7 +74,7 @@ build_CC="${NATIVE_GCC}/bin/gcc -isystem ${NATIVE_GCC}/include"
   74 build_CXX="${NATIVE_GCC}/bin/g++ -isystem ${NATIVE_GCC}/include/c++ -isystem ${NATIVE_GCC}/include"
   75 
   76 case "$HOST" in
   77-    *darwin*) export LIBRARY_PATH="${NATIVE_GCC}/lib" ;; # Required for qt/qmake
   78+    *darwin*) export LIBRARY_PATH="${NATIVE_GCC}/lib" ;; # Required for native packages
   

   ---

   ---

   

   hebasto commented at 8:14 pm on September 4, 2025:

   While the comment’s amendment is correct, the comment itself should by applied to both darwin* and mingw* hosts.

   ---

   

   fanquake commented at 11:49 pm on September 4, 2025:

   I think it’s clear it applies to both, given it’s the same code?

   ---

   

   hebasto commented at 2:21 pm on September 5, 2025:

   I think it’s clear it applies to both, given it’s the same code?

   Yes, that’s certainly one way to look at it. I’m willing to admit it might just be my own bias to think that an inline comment applies only to the specific line it’s attached to.

   That could explain why I (mistakenly) removed the comment along with the code in #32764.

10. fanquake merged this on Sep 8, 2025
11. fanquake closed this on Sep 8, 2025

    ---

12. fanquake deleted the branch on Sep 8, 2025

Contributors
fanquake DrahtBot l0rinc willcl-ark hebasto

Labels
Docs