doc: archive v29.1 release notes #33309

glozow commented at 6:15 PM on September 4, 2025: member

Copied from https://github.com/bitcoin/bitcoin/blob/v29.1/doc/release-notes.md

This is needed for announcement links and so we can see historical release notes in master.

[doc] archive v29.1 release notes 61ec8866c6

DrahtBot added the label Docs on Sep 4, 2025

DrahtBot commented at 6:15 PM on September 4, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33309.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	l0rinc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

in doc/release-notes/release-notes-29.1.md:186 in 61ec8866c6

 181 | +- #33086 contrib: [tracing] fix pointer argument handling in mempool_monitor.py
 182 | +
 183 | +Credits
 184 | +=======
 185 | +
 186 | +Thanks to everyone who directly contributed to this release:

l0rinc commented at 6:17 PM on September 4, 2025:

Are we listing coauthors here?

in doc/release-notes/release-notes-29.1.md:17 in 61ec8866c6

  12 | +To receive security and update notifications, please subscribe to:
  13 | +
  14 | +  <https://bitcoincore.org/en/list/announcements/join/>
  15 | +
  16 | +How to Upgrade
  17 | +==============

l0rinc commented at 6:20 PM on September 4, 2025:

nit: in other cases we've used the # notation instead: #33040 (review)

in doc/release-notes/release-notes-29.1.md:51 in 61ec8866c6

  46 | +  assumed to not affect any known typically formed standard transactions. The
  47 | +  change was done to prepare for a possible BIP54 deployment in the future.
  48 | +
  49 | +- #32521 policy: make pathological transactions packed with legacy sigops non-standard
  50 | +
  51 | +- The minimum block feerate (`-blockmintxfee`) has been changed to 1 satoshi per kvB. It can still be changed using the

l0rinc commented at 6:24 PM on September 4, 2025:

Should we mention the value we had before, i.e.: "has been changed from 1 satoshi per vB to 1 satoshi per kvB"

in doc/release-notes/release-notes-29.1.md:205 in 61ec8866c6

 200 | +- dergoegge
 201 | +- enirox001
 202 | +- fanquake
 203 | +- furszy
 204 | +- glozow
 205 | +- instagibbs

l0rinc commented at 6:27 PM on September 4, 2025:

nit: if this is alphabetic, this should go before ismaelsadeeq

in doc/release-notes/release-notes-29.1.md:158 in 61ec8866c6

 153 | +- #32389 doc: Fix test_bitcoin path
 154 | +- #32607 rpc: Note in fundrawtransaction doc, fee rate is for package
 155 | +- #32679 doc: update tor docs to use bitcoind binary from path
 156 | +- #32693 depends: fix cmake compatibility error for freetype
 157 | +- #32696 doc: make -DWITH_ZMQ=ON explicit on build-unix.md
 158 | +- #32708 rpc, doc: update listdescriptors RCP help

l0rinc commented at 6:45 PM on September 4, 2025:

Typo in original PR title, maybe we should fix it here at least

- [#32708](/bitcoin-bitcoin/32708/) rpc, doc: update listdescriptors RPC help

l0rinc approved

l0rinc commented at 6:48 PM on September 4, 2025: contributor

review ACK 61ec8866c63910c76c030ae828a707a71449399a

I left some suggestions, I'm fine with doing them in follow-ups or future releases or not at all. I haven't verified if the PR numbers match their descriptions (except for the RPC typo).

Could you please add some description to the PR to help others reproduce the changes here?

sipa commented at 7:08 PM on September 4, 2025: member

@l0rinc This is just an unmodified copy from the release notes from the 29.x branch: https://github.com/bitcoin/bitcoin/blob/v29.1/doc/release-notes.md, so they survive in the master branch.

l0rinc commented at 7:27 PM on September 4, 2025: contributor

Ah, so that's what the archive was referring to, thanks. Could we add that to the PR description?

maflcko commented at 7:32 PM on September 4, 2025: member

Could we add that to the PR description?

It is documented in the process: https://github.com/bitcoin/bitcoin/blob/v29.1/doc/release-process.md#after-6-or-more-people-have-guix-built-and-their-results-match

l0rinc commented at 8:02 PM on September 4, 2025: contributor

I am aware of the doc, just confused which step of the release process this was - it's why I suggested adding a description to the PR to help other reviewers. I don't see why that's a controversial take, I reviewed this because I want to help and documented the parts that I think could be helpful for other reviewers.

glozow commented at 9:52 PM on September 4, 2025: member

Added a couple of sentences to the description. I'm not going to address the review comments since this is a copy for master. In the future, these comments might be in scope on the backports and final changes PRs.

fanquake merged this on Sep 5, 2025

fanquake closed this on Sep 5, 2025