kernel: make blockTip index const #33321

1. 
   stickies-v commented at 3:01 pm on September 5, 2025: contributor

   Notification interface subscribers need to view, but not mutate, the index.

   This change allows improving the #30595 kernel interface, see e.g. BlockTreeEntry where currently a View is constructed from a non-const pointer, whereas really this should be a const btck_BlockTreeEntry* entry.

2. kernel: make blockTip index const

   Notification interface subscribers need to view, but not mutate,
   the index.

   75d9b72475
3. DrahtBot added the label Validation on Sep 5, 2025
4. 
   DrahtBot commented at 3:01 pm on September 5, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33321.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan, l0rinc, yuvicc, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30595 (kernel: Introduce initial C header API by TheCharlatan)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. TheCharlatan approved
6. 
   TheCharlatan commented at 3:16 pm on September 5, 2025: contributor

   ACK 75d9b72475708ee0da13fb23ef65dcced805b6af
7. fanquake requested review from theuni on Sep 5, 2025
8. l0rinc approved
9. 
   l0rinc commented at 4:21 pm on September 5, 2025: contributor

   Code review ACK 75d9b72475708ee0da13fb23ef65dcced805b6af
10. 
    yuvicc commented at 7:43 am on September 6, 2025: contributor

    Code review ACK 75d9b72475708ee0da13fb23ef65dcced805b6af
11. 
    achow101 commented at 8:10 pm on September 11, 2025: member

    ACK 75d9b72475708ee0da13fb23ef65dcced805b6af
12. achow101 merged this on Sep 11, 2025
13. achow101 closed this on Sep 11, 2025

    ---

14. stickies-v deleted the branch on Sep 12, 2025

Contributors
stickies-v DrahtBot TheCharlatan l0rinc yuvicc achow101

Review Requested
theuni

Labels
Validation