kernel: make blockTip index const #33321

1. 
   stickies-v commented at 3:01 PM on September 5, 2025: contributor

   Notification interface subscribers need to view, but not mutate, the index.

   This change allows improving the #30595 kernel interface, see e.g. BlockTreeEntry where currently a View is constructed from a non-const pointer, whereas really this should be a const btck_BlockTreeEntry* entry.

2. kernel: make blockTip index const

   Notification interface subscribers need to view, but not mutate,
   the index.

   75d9b72475
3. DrahtBot added the label Validation on Sep 5, 2025
4. 
   DrahtBot commented at 3:01 PM on September 5, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33321.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan, l0rinc, yuvicc, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30595 (kernel: Introduce initial C header API by TheCharlatan)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

5. sedited approved
6. 
   sedited commented at 3:16 PM on September 5, 2025: contributor

   ACK 75d9b72475708ee0da13fb23ef65dcced805b6af

7. fanquake requested review from theuni on Sep 5, 2025
8. l0rinc approved
9. 
   l0rinc commented at 4:21 PM on September 5, 2025: contributor

   Code review ACK 75d9b72475708ee0da13fb23ef65dcced805b6af

10. 
    yuvicc commented at 7:43 AM on September 6, 2025: contributor

    Code review ACK 75d9b72475708ee0da13fb23ef65dcced805b6af

11. 
    achow101 commented at 8:10 PM on September 11, 2025: member

    ACK 75d9b72475708ee0da13fb23ef65dcced805b6af

12. achow101 merged this on Sep 11, 2025
13. achow101 closed this on Sep 11, 2025

    ---

14. stickies-v deleted the branch on Sep 12, 2025
15. alexanderwiederin referenced this in commit 49e068b15b on Sep 16, 2025
16. alexanderwiederin referenced this in commit 4b0c2f2a8f on Sep 17, 2025
17. alexanderwiederin referenced this in commit 2edb618ffe on Sep 17, 2025
18. stringintech referenced this in commit fb8510ba20 on Sep 17, 2025
19. bug-castercv502 referenced this in commit 9f5d12d027 on Sep 28, 2025
20. yuvicc referenced this in commit d89c6d0002 on Sep 28, 2025
21. stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
22. Kino1994 referenced this in commit 6496fcf09c on Jun 28, 2026
23. BigcoinBGC referenced this in commit 526f197e45 on Jun 30, 2026
24. Kino1994 referenced this in commit 7450a8971d on Aug 19, 2026
25. bitcoin locked this on Sep 12, 2026

Review Requested
theuni