bench: broken CSV format, commas in benchmark names #33331

issue Raimo33 opened this issue on September 7, 2025

Raimo33 commented at 2:31 PM on September 7, 2025: contributor
Currently there are a couple of benchmarks that have commas in their name:
- SHA256D64_1024_AVX2 using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
- SHA256D64_1024_SHANI using the 'sse4(1way),sse41(4way)' SHA256 implementation
- SHA256D64_1024_SSE4 using the 'sse4(1way),sse41(4way)' SHA256 implementation
- SHA256D64_1024_STANDARD using the 'standard' SHA256 implementation
- SHA256_32b_AVX2 using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
- SHA256_32b_SHANI using the 'sse4(1way),sse41(4way)' SHA256 implementation
- SHA256_32b_SSE4 using the 'sse4(1way),sse41(4way)' SHA256 implementation
- SHA256_32b_STANDARD using the 'standard' SHA256 implementation
- SHA256_AVX2 using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
- SHA256_SHANI using the 'sse4(1way),sse41(4way)' SHA256 implementation
- SHA256_SSE4 using the 'sse4(1way),sse41(4way)' SHA256 implementation
- SHA256_STANDARD using the 'standard' SHA256 implementation
This breaks the CSV format when using ./bench_bitcoin -output-csv=bench_old.csv. Commas are allowed only as column separators in CSV.
maflcko added the label Tests on Sep 7, 2025
bitcoin deleted a comment on Sep 8, 2025
fanquake closed this on Sep 9, 2025
fanquake referenced this in commit 9cbd346daa on Sep 9, 2025
Kino1994 referenced this in commit db043982e0 on Jun 28, 2026
BigcoinBGC referenced this in commit 64d51d9b7e on Jun 30, 2026
Kino1994 referenced this in commit 2b58965b8f on Aug 19, 2026
bitcoin locked this on Sep 9, 2026

Contributors

Raimo33

Labels

Tests

Linked (view graph)

#33340 Fix benchmark CSV output