Fix benchmark CSV output #33340

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250908-fix-csv changing 1 files +4 −4
  1. hebasto commented at 11:14 AM on September 8, 2025: member

    The SHA256AutoDetect return output is used, among other use cases, to name benchmarks. Using a comma breaks the bench_bitcoin CSV output.

    This PR replaces the comma with a semicolon, which fixes #33331.

  2. DrahtBot commented at 11:14 AM on September 8, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33340.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK l0rinc, janb84, Raimo33

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. in src/crypto/sha256.cpp:628 in aed00d901d outdated 
     624 | @@ -625,7 +625,7 @@ std::string SHA256AutoDetect(sha256_implementation::UseImplementation use_implem
 625 |          Transform = sha256_x86_shani::Transform;
 626 |          TransformD64 = TransformD64Wrapper<sha256_x86_shani::Transform>;
 627 |          TransformD64_2way = sha256d64_x86_shani::Transform_2way;
 628 | -        ret = "x86_shani(1way,2way)";
 629 | +        ret = "x86_shani(1way;2way)";
    l0rinc commented at 5:29 PM on September 8, 2025:

    We should likely update the arm version as well:

    hebasto commented at 5:40 PM on September 8, 2025:

    Thanks! Fixed.

  4. l0rinc changes_requested
  5. Fix benchmark CSV output
    The `SHA256AutoDetect` return output is used, among other use cases, to
name benchmarks. Using a comma breaks the CSV output.

This change replaces the comma with a semicolon, which fixes the issue.
    790b440197
  6. hebasto force-pushed on Sep 8, 2025
  7. l0rinc approved
  8. l0rinc commented at 5:41 PM on September 8, 2025: contributor

    Code review ACK 790b440197bde322432a5bab161f1869b667e681

  9. janb84 commented at 6:33 PM on September 8, 2025: contributor

    code review ACK 790b440197bde322432a5bab161f1869b667e681

    PR changes the comma's from the static text in the SHA256AutoDetect return output to semicolons so that it will not interfere with Comma-Separated Values (CSV) output.

  10. Raimo33 commented at 8:13 PM on September 8, 2025: contributor

    Code Review ACK 790b440197bde322432a5bab161f1869b667e681

  11. fanquake merged this on Sep 9, 2025
  12. fanquake closed this on Sep 9, 2025
  13. fanquake referenced this in commit 2717331981 on Sep 9, 2025
  14. hebasto deleted the branch on Sep 9, 2025
  15. alexanderwiederin referenced this in commit 49e068b15b on Sep 16, 2025
  16. alexanderwiederin referenced this in commit 4b0c2f2a8f on Sep 17, 2025
  17. alexanderwiederin referenced this in commit 2edb618ffe on Sep 17, 2025
  18. fanquake referenced this in commit e94515b919 on Sep 17, 2025
  19. fanquake commented at 2:18 PM on September 17, 2025: member

    Backported to 28.x in #33415 & 29.x in #33344.

  20. glozow referenced this in commit 7e1eca4882 on Sep 17, 2025
  21. stringintech referenced this in commit fb8510ba20 on Sep 17, 2025
  22. fanquake referenced this in commit a381de750d on Sep 24, 2025
  23. achow101 referenced this in commit a0b5730f85 on Sep 25, 2025
  24. bug-castercv502 referenced this in commit 9f5d12d027 on Sep 28, 2025
  25. yuvicc referenced this in commit d89c6d0002 on Sep 28, 2025
  26. stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
  27. morozow referenced this in commit 1aad3572ca on May 8, 2026
  28. morozow referenced this in commit 00232b7453 on May 8, 2026
  29. morozow referenced this in commit f7f635c2c3 on May 8, 2026
  30. morozow referenced this in commit 3848de1a09 on May 8, 2026
  31. Kino1994 referenced this in commit db043982e0 on Jun 28, 2026
  32. BigcoinBGC referenced this in commit 64d51d9b7e on Jun 30, 2026
  33. Kino1994 referenced this in commit 2b58965b8f on Aug 19, 2026
  34. bitcoin locked this on Sep 17, 2026
Contributors
hebastoDrahtBotl0rincjanb84Raimo33fanquake
Linked (view graph)
#33331 bench: broken CSV format, commas in benchmark names#33344 [29.x] Backports#33415 [28.x] More backports
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-05 21:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me