contrib: fix for macOS deployment build failing on Qt translations even though it is optional. #33358

1. 
   amishhaa commented at 4:32 pm on September 10, 2025: none

   From what I deciphered reading the line https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/macdeployqtplus#L390 is that qt translations are optional to have hence we should be able to build without it but the case where the flag translations_dir falls back to its default Null value it raises this error. I have moved the code which adds language files under the if statement that first checks if the value of the flag is not Null before referencing it. This PR assumes that having Qt translations is optional however this statement requires a second opinion. Build completes successfully post this change with default value of the flag.

2. DrahtBot added the label Scripts and tools on Sep 10, 2025
3. 
   DrahtBot commented at 4:32 pm on September 10, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33358.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. 
   fanquake commented at 8:19 pm on September 23, 2025: member

   Thanks. You’ll need to remove the merge commit here. Can you change the commit message to something more like: contrib: fix using macdeploy script without translations.
5. amishhaa force-pushed on Sep 23, 2025
6. amishhaa force-pushed on Sep 23, 2025
7. 
   amishhaa commented at 11:53 pm on September 23, 2025: none

   @fanquake yes!, done.
8. 
   fanquake commented at 1:38 am on September 24, 2025: member

   gui: Avoid pathological QT text/markdown behavior… during text selection by only setting plaintext mime data. @amishhaa looks like you’ve got a partial commit message from a prior commit in this repo, as part of your commit message?

9. amishhaa force-pushed on Sep 25, 2025
10. amishhaa force-pushed on Sep 25, 2025
11. amishhaa force-pushed on Sep 25, 2025
12. 
    amishhaa commented at 4:02 am on September 25, 2025: none

    @fanquake, sorry for the delay! fixed.
13. 
    hebasto commented at 11:38 am on September 25, 2025: member

    @amishhaa

    Would you mind sharing the steps to reproduce the failure?

14. 
    amishhaa commented at 1:10 pm on September 25, 2025: none

    @hebasto yes! So I was following the general steps to set up app on macos however I didn’t download any qt translations presuming it was optional from the comment linkedin in PR, so to reproduce if you have translation directories in place ull need to delete them and then try to build the file, otherwise don’t download it at all and try to build it. It should fail on that flag as translations dir was never downloaded.
15. amishhaa force-pushed on Sep 26, 2025
16. amishhaa closed this on Sep 26, 2025

    ---

17. amishhaa force-pushed on Sep 26, 2025
18. 
    amishhaa commented at 5:38 am on September 26, 2025: none

    Closed this PR due to some local branching issues. Reopened #33482 with a clean working tree. (cc: @hebasto, @fanquake )

Contributors
amishhaa DrahtBot fanquake hebasto

Labels
Scripts and tools