contrib: fix for macOS deployment build failing on Qt translations even though it is optional. #33358

pull amishhaa wants to merge 2 commits into bitcoin:master from amishhaa:master changing 1 files +8 −8

amishhaa commented at 4:32 pm on September 10, 2025: none

From what I deciphered reading the line https://github.com/bitcoin/bitcoin/blob/master/contrib/macdeploy/macdeployqtplus#L390 is that qt translations are optional to have hence we should be able to build without it but the case where the flag translations_dir falls back to its default Null value it raises this error. I have moved the code which adds language files under the if statement that first checks if the value of the flag is not Null before referencing it. This PR assumes that having Qt translations is optional however this statement requires a second opinion. Build completes successfully post this change with default value of the flag.
making qt translations optional while building d732b23f3d
Merge branch 'bitcoin:master' into master 4199baa7db
DrahtBot added the label Scripts and tools on Sep 10, 2025
DrahtBot commented at 4:32 pm on September 10, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33358.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.