Currently when running on GH free runners, this jobs runs out of space. This does not happen on Cirrus runners in the main repo (bitcoin/bitcoin) but does happen on forks.
Rather than include code to free up space on the runner image, disable this job on forks.
Fixes #33293
Currently when running on GH free runners, this jobs runs out of space.
This does not happen on Cirrus runners in the main repo
(bitcoin/bitcoin) but does happen on forks.
Rather than include code to free up space on the runner image, disable
this job on forks.
Ref #33293
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33365.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept NACK | m3dwards |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Possible typos and grammar issues:
drahtbot_id_5_m
I did trial freeing up space on the runner as suggested by @maflcko in #33293, and it is possible to free up 18GB realtively easily, using e.g. https://github.com/willcl-ark/bitcoin/blob/f5885d05160fe0ac167976f2b36b6d5bec373e08/.github/actions/clear-files/action.yml
But a one-line disable feels much cleaner, and also removes us from maintaing code in this repo, which isn’t for our own use.
To be clear, this will start skipping the job in bitcoin-core/gui ?
That is currently correct, as I understand it.
Though I thought I heard that @m3dwards had been successful in persuading Cirrus to allow us to share our runners with both orgs? In which case it would automagically work there when USE_CIRRUS_RUNNERS was set.
Looks fine. I don’t have strong feelings, and wouldn’t NACK this, but my preference leans more towards having things still run on forks on GHA runners as it does for the main org albeit slower. Also has the benefit of having a bit less vendor lock in.
I think if I was to e.g. append || true to the commands in https://github.com/willcl-ark/bitcoin/blob/f5885d05160fe0ac167976f2b36b6d5bec373e08/.github/actions/clear-files/action.yml to make it “fail-proof” (i.e. don’t error on failures) then it could be acceptable to have that code in this repo, even if only for forks?
I’m happy with either fix, or a new solution not yet proposed :)
It seems a bit odd to have this task here, but not on forks. Somehow defeats the point of even supporting GHA runners, if they don’t run the same matrix.
So I think I’d go with the clear-files action, albeit it is ugly to have to maintain it here.
Although, in the meantime, it seems to be passing: https://github.com/fanquake/bitcoin/actions/runs/17928384544/job/50981349378?