The diff in the copied header is:
0< #if __STDC_VERSION__ >= 199901L
1---
2> #if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
From https://sourceware.org/git/?p=systemtap.git;a=commit;h=b8345d8e07b725a943a97b19aa4866e74baadd98.
depends: systemtap 5.3 #33373
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:systemtap_5_3 changing 1 files +2 −2-
fanquake commented at 11:01 am on September 12, 2025: member
-
28efd724b4
depends: systemtap 5.3
The diff in the copied header is: ```diff < #if __STDC_VERSION__ >= 199901L --- > #if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L ``` From https://sourceware.org/git/?p=systemtap.git;a=commit;h=b8345d8e07b725a943a97b19aa4866e74baadd98.
-
DrahtBot added the label Build system on Sep 12, 2025
-
DrahtBot commented at 11:01 am on September 12, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33373.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK 0xB10C If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
fanquake requested review from 0xB10C on Sep 12, 2025
-
fanquake added the label DrahtBot Guix build requested on Sep 12, 2025
-
fanquake commented at 12:18 pm on September 12, 2025: member
Guix Build:
0860c39a3db7eb7e8aaf8165cd6834d2fd87afc69b82b20203a013c7ad7e7b057 guix-build-28efd724b478/output/aarch64-linux-gnu/SHA256SUMS.part 1841aea1c04fd996bc437ae0d7a59f4e7feb52a21c0d810489aa87654c38d7b55 guix-build-28efd724b478/output/aarch64-linux-gnu/bitcoin-28efd724b478-aarch64-linux-gnu-debug.tar.gz 21b5fee5de6da1981518dd6c04542e0194a810abe9911ee4844f9c8c546279b6a guix-build-28efd724b478/output/aarch64-linux-gnu/bitcoin-28efd724b478-aarch64-linux-gnu.tar.gz 343d8427e5b93fb909ee3fa258e9dc31fbdc5b6c52345a533eeda03540f9bb34e guix-build-28efd724b478/output/arm-linux-gnueabihf/SHA256SUMS.part 493e470a5e562d18cb8b3ffa94e1ef01acd589515ab194155a8c235764ab87626 guix-build-28efd724b478/output/arm-linux-gnueabihf/bitcoin-28efd724b478-arm-linux-gnueabihf-debug.tar.gz 5d43ba457e0f0b8f2a94c0ca275e4362f2de51dfed604242846e7bbfe62eedc96 guix-build-28efd724b478/output/arm-linux-gnueabihf/bitcoin-28efd724b478-arm-linux-gnueabihf.tar.gz 64ec1277362492e81fb04e5e4ed1650f6e164d32475719852da696be21054f8fe guix-build-28efd724b478/output/arm64-apple-darwin/SHA256SUMS.part 75921117fd6b4326316f121de66fd760477eae8d7c95d998658a739e7d503a8db guix-build-28efd724b478/output/arm64-apple-darwin/bitcoin-28efd724b478-arm64-apple-darwin-codesigning.tar.gz 82680dee361d7bc11c5514d26516298cdce21bdb8f300fb2d687f4a6d5968f0b6 guix-build-28efd724b478/output/arm64-apple-darwin/bitcoin-28efd724b478-arm64-apple-darwin-unsigned.tar.gz 943fb74424ec70638b82c9d21528ed23a4bab463a528799f1f5d7118a26180887 guix-build-28efd724b478/output/arm64-apple-darwin/bitcoin-28efd724b478-arm64-apple-darwin-unsigned.zip 10942a4b2df0c1b3fc678874da2e8498ecb76b809f1a1b2cafd140ef8eb7a7c3c4 guix-build-28efd724b478/output/dist-archive/bitcoin-28efd724b478.tar.gz 113f8581bb77de1ef56f433c41b6c2df106058d17ac2e12989fed7ad7316eb26f9 guix-build-28efd724b478/output/powerpc64-linux-gnu/SHA256SUMS.part 122b153f8d9dc73c812258c399d9f69b26e88c938c2e96cc8f2bac59bf9b9f2776 guix-build-28efd724b478/output/powerpc64-linux-gnu/bitcoin-28efd724b478-powerpc64-linux-gnu-debug.tar.gz 13b69da88ca19821f641f44aa29080ab16e26ca86c6ad07e4442a49baf68402c89 guix-build-28efd724b478/output/powerpc64-linux-gnu/bitcoin-28efd724b478-powerpc64-linux-gnu.tar.gz 14db557e2c78dbbaa242298e712bae99c897ef5e61ac4077bce1fae34f1c76641d guix-build-28efd724b478/output/riscv64-linux-gnu/SHA256SUMS.part 151841206a9c9544ae439ca0acad124c812d5ad553585a97ef2f450125cee47f40 guix-build-28efd724b478/output/riscv64-linux-gnu/bitcoin-28efd724b478-riscv64-linux-gnu-debug.tar.gz 16f73237c499930f018d85f39bdc21edcbf545c1ceba3a257ceba51b1a0a91e119 guix-build-28efd724b478/output/riscv64-linux-gnu/bitcoin-28efd724b478-riscv64-linux-gnu.tar.gz 177570bfd25ab6298961544f339004c37020677a4bcf457bdd7971dacc27dd60aa guix-build-28efd724b478/output/x86_64-apple-darwin/SHA256SUMS.part 18784120520010258483e41e62cb01aa80daa2f8610fa678abaa434b88564e04c6 guix-build-28efd724b478/output/x86_64-apple-darwin/bitcoin-28efd724b478-x86_64-apple-darwin-codesigning.tar.gz 199b38a1b50a486572e1c10185c3c3233273a20b251fcf91bebf6bd8d55ca44fc6 guix-build-28efd724b478/output/x86_64-apple-darwin/bitcoin-28efd724b478-x86_64-apple-darwin-unsigned.tar.gz 20b0a4acb2cdbad5be226a6f892b22eb02a6808c02bcdd6ab86138dde53d34bd9c guix-build-28efd724b478/output/x86_64-apple-darwin/bitcoin-28efd724b478-x86_64-apple-darwin-unsigned.zip 21bdbc32eb313c895476a4a57ceeda9c916fa375742dc49e168c364f2ff413f070 guix-build-28efd724b478/output/x86_64-linux-gnu/SHA256SUMS.part 22c244eaae72d9846c2c508b02b8af19a08f4f061f6067d5828378f31f5569d677 guix-build-28efd724b478/output/x86_64-linux-gnu/bitcoin-28efd724b478-x86_64-linux-gnu-debug.tar.gz 23d7c926c87d39edbf29bda975fad7e525923ddbfe8ccf18700fb6520e3e6204af guix-build-28efd724b478/output/x86_64-linux-gnu/bitcoin-28efd724b478-x86_64-linux-gnu.tar.gz 2478c041aec1453304181a689abf36d2f0db26ed6f0030a52248be17aae873950d guix-build-28efd724b478/output/x86_64-w64-mingw32/SHA256SUMS.part 25df44eb40ba69c699b21bbe7251391b4b2ddcaa105e7843374c428c6b7261acc0 guix-build-28efd724b478/output/x86_64-w64-mingw32/bitcoin-28efd724b478-win64-codesigning.tar.gz 261416475f5ec2505f0f1e67e5fa6a96a9cac156008071eaf6dd6e66f3a69bc6c1 guix-build-28efd724b478/output/x86_64-w64-mingw32/bitcoin-28efd724b478-win64-debug.zip 271421ffa73d1fc603bc2086edc8637a38ada6d90a9f2cbf82e1537f2d625d2a40 guix-build-28efd724b478/output/x86_64-w64-mingw32/bitcoin-28efd724b478-win64-setup-unsigned.exe 2834a2ceb2d535d173add5fb4e2cbff6ca58d8a4136c127ebda4d5f6791afe47bb guix-build-28efd724b478/output/x86_64-w64-mingw32/bitcoin-28efd724b478-win64-unsigned.zip -
DrahtBot commented at 2:33 am on September 13, 2025: contributor
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]
File commit 9a5ba154bea183fb13d413e095df0c14990e2bf6(master) commit 5a95127cd4414da10365e4dc8b7597879dec9a60(pull/33373/merge) *-aarch64-linux-gnu-debug.tar.gz 1af123edb13ff40e...75f9025e8d1443db...*-aarch64-linux-gnu.tar.gz 3727c3d28a2d988a...8a4fbcf9f092772c...*-arm-linux-gnueabihf-debug.tar.gz d27ee65a4b794c26...036910b3a1f1cd9f...*-arm-linux-gnueabihf.tar.gz 1dcf5ad499f4f8f8...7505a589e687db45...*-arm64-apple-darwin-codesigning.tar.gz f905df9242955966...04a9a0ecc2a2e9a0...*-arm64-apple-darwin-unsigned.tar.gz 66689984ab12cb0d...78ae859682d581e2...*-arm64-apple-darwin-unsigned.zip 26fef77e3eb67221...7a537ec971e8fd73...*-powerpc64-linux-gnu-debug.tar.gz eab16c01109c6260...fd15e5734de7e3cd...*-powerpc64-linux-gnu.tar.gz 5e0bc03fed4c533c...54ad14d4dd087866...*-riscv64-linux-gnu-debug.tar.gz 2f3129246d45865e...a6f97d0bbe2feb20...*-riscv64-linux-gnu.tar.gz 02a523d33ea3f489...350ccf16341e5903...*-x86_64-apple-darwin-codesigning.tar.gz 1c1c8c9fbe4f5cdf...05715a7f811ec88c...*-x86_64-apple-darwin-unsigned.tar.gz 402e422ef96cfd1a...9f2ad8aea34059ab...*-x86_64-apple-darwin-unsigned.zip 9f8691358e6ad9ed...300137fa1b31e8e2...*-x86_64-linux-gnu-debug.tar.gz 1e53e28945180b42...a7c218a44cc971f3...*-x86_64-linux-gnu.tar.gz 62eae6bb64ba7fa7...acf96486bad08234...*.tar.gz 66dda3393f3f7819...45b77af3a94d848d...SHA256SUMS.part b36ed65a2fe8db0f...a9cd57b78afbee37...guix_build.log 255e6f4b074e832c...65a598152c952ab4...guix_build.log.diff 5084cde87eb37265... -
DrahtBot removed the label DrahtBot Guix build requested on Sep 13, 2025
-
0xB10C approved
-
0xB10C commented at 9:51 am on September 15, 2025: contributor
ACK 28efd724b47841a16d0630cec4b59563cda54a81
I agree that the package sha256 hash is
966a360fb73a4b65a8d0b51b389577b3c4f92a327e84aae58682103e8c65a69a. The upstream diff is minimal and looks fine. The guix build hashes match.0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum 1860c39a3db7eb7e8aaf8165cd6834d2fd87afc69b82b20203a013c7ad7e7b057 guix-build-28efd724b478/output/aarch64-linux-gnu/SHA256SUMS.part 2841aea1c04fd996bc437ae0d7a59f4e7feb52a21c0d810489aa87654c38d7b55 guix-build-28efd724b478/output/aarch64-linux-gnu/bitcoin-28efd724b478-aarch64-linux-gnu-debug.tar.gz 31b5fee5de6da1981518dd6c04542e0194a810abe9911ee4844f9c8c546279b6a guix-build-28efd724b478/output/aarch64-linux-gnu/bitcoin-28efd724b478-aarch64-linux-gnu.tar.gz 443d8427e5b93fb909ee3fa258e9dc31fbdc5b6c52345a533eeda03540f9bb34e guix-build-28efd724b478/output/arm-linux-gnueabihf/SHA256SUMS.part 593e470a5e562d18cb8b3ffa94e1ef01acd589515ab194155a8c235764ab87626 guix-build-28efd724b478/output/arm-linux-gnueabihf/bitcoin-28efd724b478-arm-linux-gnueabihf-debug.tar.gz 6d43ba457e0f0b8f2a94c0ca275e4362f2de51dfed604242846e7bbfe62eedc96 guix-build-28efd724b478/output/arm-linux-gnueabihf/bitcoin-28efd724b478-arm-linux-gnueabihf.tar.gz 74ec1277362492e81fb04e5e4ed1650f6e164d32475719852da696be21054f8fe guix-build-28efd724b478/output/arm64-apple-darwin/SHA256SUMS.part 85921117fd6b4326316f121de66fd760477eae8d7c95d998658a739e7d503a8db guix-build-28efd724b478/output/arm64-apple-darwin/bitcoin-28efd724b478-arm64-apple-darwin-codesigning.tar.gz 92680dee361d7bc11c5514d26516298cdce21bdb8f300fb2d687f4a6d5968f0b6 guix-build-28efd724b478/output/arm64-apple-darwin/bitcoin-28efd724b478-arm64-apple-darwin-unsigned.tar.gz 1043fb74424ec70638b82c9d21528ed23a4bab463a528799f1f5d7118a26180887 guix-build-28efd724b478/output/arm64-apple-darwin/bitcoin-28efd724b478-arm64-apple-darwin-unsigned.zip 11942a4b2df0c1b3fc678874da2e8498ecb76b809f1a1b2cafd140ef8eb7a7c3c4 guix-build-28efd724b478/output/dist-archive/bitcoin-28efd724b478.tar.gz 123f8581bb77de1ef56f433c41b6c2df106058d17ac2e12989fed7ad7316eb26f9 guix-build-28efd724b478/output/powerpc64-linux-gnu/SHA256SUMS.part 132b153f8d9dc73c812258c399d9f69b26e88c938c2e96cc8f2bac59bf9b9f2776 guix-build-28efd724b478/output/powerpc64-linux-gnu/bitcoin-28efd724b478-powerpc64-linux-gnu-debug.tar.gz 14b69da88ca19821f641f44aa29080ab16e26ca86c6ad07e4442a49baf68402c89 guix-build-28efd724b478/output/powerpc64-linux-gnu/bitcoin-28efd724b478-powerpc64-linux-gnu.tar.gz 15db557e2c78dbbaa242298e712bae99c897ef5e61ac4077bce1fae34f1c76641d guix-build-28efd724b478/output/riscv64-linux-gnu/SHA256SUMS.part 161841206a9c9544ae439ca0acad124c812d5ad553585a97ef2f450125cee47f40 guix-build-28efd724b478/output/riscv64-linux-gnu/bitcoin-28efd724b478-riscv64-linux-gnu-debug.tar.gz 17f73237c499930f018d85f39bdc21edcbf545c1ceba3a257ceba51b1a0a91e119 guix-build-28efd724b478/output/riscv64-linux-gnu/bitcoin-28efd724b478-riscv64-linux-gnu.tar.gz 187570bfd25ab6298961544f339004c37020677a4bcf457bdd7971dacc27dd60aa guix-build-28efd724b478/output/x86_64-apple-darwin/SHA256SUMS.part 19784120520010258483e41e62cb01aa80daa2f8610fa678abaa434b88564e04c6 guix-build-28efd724b478/output/x86_64-apple-darwin/bitcoin-28efd724b478-x86_64-apple-darwin-codesigning.tar.gz 209b38a1b50a486572e1c10185c3c3233273a20b251fcf91bebf6bd8d55ca44fc6 guix-build-28efd724b478/output/x86_64-apple-darwin/bitcoin-28efd724b478-x86_64-apple-darwin-unsigned.tar.gz 21b0a4acb2cdbad5be226a6f892b22eb02a6808c02bcdd6ab86138dde53d34bd9c guix-build-28efd724b478/output/x86_64-apple-darwin/bitcoin-28efd724b478-x86_64-apple-darwin-unsigned.zip 22bdbc32eb313c895476a4a57ceeda9c916fa375742dc49e168c364f2ff413f070 guix-build-28efd724b478/output/x86_64-linux-gnu/SHA256SUMS.part 23c244eaae72d9846c2c508b02b8af19a08f4f061f6067d5828378f31f5569d677 guix-build-28efd724b478/output/x86_64-linux-gnu/bitcoin-28efd724b478-x86_64-linux-gnu-debug.tar.gz 24d7c926c87d39edbf29bda975fad7e525923ddbfe8ccf18700fb6520e3e6204af guix-build-28efd724b478/output/x86_64-linux-gnu/bitcoin-28efd724b478-x86_64-linux-gnu.tar.gz 2578c041aec1453304181a689abf36d2f0db26ed6f0030a52248be17aae873950d guix-build-28efd724b478/output/x86_64-w64-mingw32/SHA256SUMS.part 26df44eb40ba69c699b21bbe7251391b4b2ddcaa105e7843374c428c6b7261acc0 guix-build-28efd724b478/output/x86_64-w64-mingw32/bitcoin-28efd724b478-win64-codesigning.tar.gz 271416475f5ec2505f0f1e67e5fa6a96a9cac156008071eaf6dd6e66f3a69bc6c1 guix-build-28efd724b478/output/x86_64-w64-mingw32/bitcoin-28efd724b478-win64-debug.zip 281421ffa73d1fc603bc2086edc8637a38ada6d90a9f2cbf82e1537f2d625d2a40 guix-build-28efd724b478/output/x86_64-w64-mingw32/bitcoin-28efd724b478-win64-setup-unsigned.exe 2934a2ceb2d535d173add5fb4e2cbff6ca58d8a4136c127ebda4d5f6791afe47bb guix-build-28efd724b478/output/x86_64-w64-mingw32/bitcoin-28efd724b478-win64-unsigned.zip -
fanquake merged this on Sep 16, 2025
-
fanquake closed this on Sep 16, 2025
-
fanquake deleted the branch on Sep 16, 2025
Labels
Build system
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-18 15:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-18 15:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me