cmake: exclude secp256k1 from all #33390

1. 
   purpleKarrot commented at 1:11 pm on September 15, 2025: contributor

   Instead of setting the EXCLUDE_FROM_ALL target property, pass EXCLUDE_FROM_ALL to add_subdirectory().

   This has the following advanteges:

   • It is shorter (obviously).
   • Target properties are set only in the CMakeLists.txt file that defines the target.
   • Install rules defined in the subdirectory are excluded as well. This is what we want, because secp256k1 is linked statically.
2. cmake: exclude secp256k1 from all

   Instead of setting the EXCLUDE_FROM_ALL target property, pass
   EXCLUDE_FROM_ALL to `add_subdirectory()`.

   a5bc50eb12
3. DrahtBot added the label Build system on Sep 15, 2025
4. 
   DrahtBot commented at 1:11 pm on September 15, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33390.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #33282 (cmake: fatal error when PIE not supported by stickies-v)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   hebasto commented at 1:14 pm on September 15, 2025: member

   CI fails:

   0The following tests FAILED:
   1	  4 - secp256k1_noverify_tests (Not Run)
   2	  5 - secp256k1_tests (Not Run)
   3	  6 - secp256k1_exhaustive_tests (Not Run)
   4Errors while running CTest
   

Contributors
purpleKarrot DrahtBot hebasto

Labels
Build system