cmake: exclude secp256k1 from all #33390

pull purpleKarrot wants to merge 1 commits into bitcoin:master from purpleKarrot:secp256k1-exclude-from-all changing 1 files +1 −4
  1. purpleKarrot commented at 1:11 PM on September 15, 2025: contributor

    Instead of setting the EXCLUDE_FROM_ALL target property, pass EXCLUDE_FROM_ALL to add_subdirectory().

    This has the following advanteges:

    • It is shorter (obviously).
    • Target properties are set only in the CMakeLists.txt file that defines the target.
    • Install rules defined in the subdirectory are excluded as well. This is what we want, because secp256k1 is linked statically.
  2. cmake: exclude secp256k1 from all
    Instead of setting the EXCLUDE_FROM_ALL target property, pass
    EXCLUDE_FROM_ALL to `add_subdirectory()`.
    a5bc50eb12
  3. DrahtBot added the label Build system on Sep 15, 2025
  4. DrahtBot commented at 1:11 PM on September 15, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33390.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. hebasto commented at 1:14 PM on September 15, 2025: member

    CI fails:

    The following tests FAILED:
    	  4 - secp256k1_noverify_tests (Not Run)
    	  5 - secp256k1_tests (Not Run)
    	  6 - secp256k1_exhaustive_tests (Not Run)
    Errors while running CTest
    
  6. maflcko commented at 8:16 AM on September 26, 2025: member

    Could turn into draft while CI is red?

  7. fanquake marked this as a draft on Sep 28, 2025
  8. fanquake commented at 11:23 AM on January 22, 2026: member

    Are you still working on this?

  9. fanquake commented at 10:17 AM on February 9, 2026: member

    This has been in draft for 5 months, and the CI has never been passing, so closing for now. Feel free to comment if you want this reopened.

  10. fanquake closed this on Feb 9, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me