refactor: Fix typo and correct template parameter inconsistency #33394

pull sekomer wants to merge 1 commits into bitcoin:master from sekomer:master changing 2 files +10 −10
  1. sekomer commented at 8:05 pm on September 15, 2025: none
    • Fixed typo in merkle.cpp where variable was named ‘matchh’ instead of ‘match’
    • Fixed Hash160 to use ‘T’ instead of ‘T1’ for single template parameter, making it consistent with other single-parameter template functions like Hash

    Impact

    These are refactoring changes with no functional impact:

    • No behavior changes
    • No consensus changes
    • All existing tests pass without modification
    • Improves code maintainability and reduces cognitive load for developers
  2. refactor: Fix typo and correct template parameter inconsistency
    - Fixed typo in merkle.cpp where variable was named 'matchh' instead of 'match'
    - Fixed Hash160 to use 'T' instead of 'T1' for single template parameter,
      making it consistent with other single-parameter template functions like Hash<T>
    0fd1347aea
  3. DrahtBot added the label Refactoring on Sep 15, 2025
  4. DrahtBot commented at 8:05 pm on September 15, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33394.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept NACK optout21

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • Compute the 160-bit hash an object. -> Compute the 160-bit hash of an object. [missing “of”, which makes the sentence ungrammatical]

    drahtbot_id_5_m

  5. optout21 commented at 9:01 am on September 16, 2025: none
    Concept NACK Though the changes are reasonable, I don’t think a typo fix in a variable name justifies a separate PR.
  6. fanquake commented at 11:04 am on September 16, 2025: member
    Thanks, however I think this code can be left as-is for now.
  7. fanquake closed this on Sep 16, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-18 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me