There were quite a few places where assert() was used with side effects, making operation with NDEBUG non-functional. This commit fixes all the cases I know about, but also adds an #error on NDEBUG because the code is untested without assertions and may still have vulnerabilities if used without assert.
Sanitize assert usage and refuse to compile with NDEBUG. #3344
pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:assert_hazards changing 3 files +23 −7-
gmaxwell commented at 7:38 PM on December 2, 2013: contributor
-
9b59e3bda8
Sanitize assert usage and refuse to compile with NDEBUG.
There were quite a few places where assert() was used with side effects, making operation with NDEBUG non-functional. This commit fixes all the cases I know about, but also adds an #error on NDEBUG because the code is untested without assertions and may still have vulnerabilities if used without assert.
-
BitcoinPullTester commented at 8:00 PM on December 2, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9b59e3bda8c137bff885db5b1f9150346e36e076 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
gavinandresen commented at 12:56 AM on December 3, 2013: contributor
ACK.
Merging because it is obviously better.
- gavinandresen referenced this in commit 2aed2b30b1 on Dec 3, 2013
- gavinandresen merged this on Dec 3, 2013
- gavinandresen closed this on Dec 3, 2013
- DrahtBot locked this on Sep 8, 2021
Contributors