TxGraph: change m_excluded_clusters #33469

1. 
   instagibbs commented at 8:32 pm on September 23, 2025: member

   Change BlockBuilderImpl’s m_excluded_clusters to unordered set since ordering is not used.

   Change the set to a set of sequence numbers for a modest stability increase under fuzz testing.

2. 
   DrahtBot commented at 8:32 pm on September 23, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33469.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipa, marcofleon, glozow

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

3. 
   instagibbs commented at 8:33 pm on September 23, 2025: member

   h/t @marcofleon for validation of changes
4. fanquake marked this as a draft on Sep 23, 2025
5. TxGraph: change m_excluded_clusters

   Change BlockBuilderImpl's m_excluded_clusters to unordered
   set since ordering is not used.
   
   Change the set to a set of sequence numbers for a modest
   stability increase under fuzz testing.

   9b43428c96
6. instagibbs force-pushed on Oct 14, 2025
7. instagibbs marked this as ready for review on Oct 14, 2025
8. 
   instagibbs commented at 4:50 pm on October 14, 2025: member

   ready for review
9. 
   sipa commented at 6:13 pm on October 14, 2025: member

   ACK 9b43428c96872f0fbbbab4c066c6010fc18c6cc4

   Ran 10M fuzz iterations. Must be good.

10. 
    marcofleon commented at 1:39 pm on October 15, 2025: contributor

    tACK 9b43428c96872f0fbbbab4c066c6010fc18c6cc4

    AFL++ now showing 94.5% stability for the txgraph target with this change.

    edit: For reference, it was 94% previously.

11. 
    glozow commented at 1:58 pm on October 15, 2025: member

    ACK 9b43428c96872f0fbbbab4c066c6010fc18c6cc4
12. glozow merged this on Oct 15, 2025
13. glozow closed this on Oct 15, 2025

    ---

Contributors
instagibbs DrahtBot sipa marcofleon glozow