Change BlockBuilderImpl's m_excluded_clusters to unordered set since ordering is not used.
Change the set to a set of sequence numbers for a modest stability increase under fuzz testing.
TxGraph: change m_excluded_clusters #33469
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2025-09-unordered_blockbuilder changing 1 files +6 −4-
instagibbs commented at 8:32 PM on September 23, 2025: member
-
DrahtBot commented at 8:32 PM on September 23, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33469.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK sipa, marcofleon, glozow If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
instagibbs commented at 8:33 PM on September 23, 2025: member
h/t @marcofleon for validation of changes
- fanquake marked this as a draft on Sep 23, 2025
-
9b43428c96
TxGraph: change m_excluded_clusters
Change BlockBuilderImpl's m_excluded_clusters to unordered set since ordering is not used. Change the set to a set of sequence numbers for a modest stability increase under fuzz testing.
- instagibbs force-pushed on Oct 14, 2025
- instagibbs marked this as ready for review on Oct 14, 2025
-
instagibbs commented at 4:50 PM on October 14, 2025: member
ready for review
-
sipa commented at 6:13 PM on October 14, 2025: member
ACK 9b43428c96872f0fbbbab4c066c6010fc18c6cc4
Ran 10M fuzz iterations. Must be good.
-
marcofleon commented at 1:39 PM on October 15, 2025: contributor
tACK 9b43428c96872f0fbbbab4c066c6010fc18c6cc4
AFL++ now showing 94.5% stability for the
txgraphtarget with this change.edit: For reference, it was 94% previously.
-
glozow commented at 1:58 PM on October 15, 2025: member
ACK 9b43428c96872f0fbbbab4c066c6010fc18c6cc4
- glozow merged this on Oct 15, 2025
- glozow closed this on Oct 15, 2025
Contributors