build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script

151henry151 commented at 11:19 pm on September 23, 2025: none

Remove hardcoded CMAKE_SKIP_INSTALL_RPATH setting from CMakeLists.txt and add it as a CMake configuration option in the Guix build script. This makes the build system more portable by keeping build-environment-specific settings in the build scripts rather than hardcoded in the CMake configuration.

Changes:

Remove set(CMAKE_SKIP_INSTALL_RPATH TRUE) from CMakeLists.txt
Add -DCMAKE_SKIP_INSTALL_RPATH=TRUE to Guix build script cmake configuration

This addresses the feedback from hebasto in #33247 (review)

Build system improvements that make the CMake configuration more generic and portable.

DrahtBot added the label Build system on Sep 23, 2025

DrahtBot commented at 11:19 pm on September 23, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33470.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#33247 (build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings by 151henry151)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

151henry151 commented at 4:47 am on September 24, 2025: none

Guix build hashes for commit eb98b612f80f:

698ad81e49ed8fe64d3586fe7a87837c82fef4b0ec8477f1737587593eff424a dist-archive/bitcoin-eb98b612f80f.tar.gz 2e1cbd7e66128739582a7822c6ac06fc57b33061d0cbbcd86094dbc4624c02e5 x86_64-linux-gnu/bitcoin-eb98b612f80f-x86_64-linux-gnu-debug.tar.gz be406dc0f71c160a2a4173ff81b29f67e2b191a3331eaf4d6d905e7fd07e646b x86_64-linux-gnu/bitcoin-eb98b612f80f-x86_64-linux-gnu.tar.gz

Build completed successfully on Linux x86_64.

maflcko added the label DrahtBot Guix build requested on Sep 24, 2025

build: Move CMAKE_SKIP_RPATH from CMake to Guix script

Remove hardcoded CMAKE_SKIP_INSTALL_RPATH setting from CMakeLists.txt and add it as a CMake configuration option in the Guix build script. This makes the build system more portable by keeping build-environment-specific settings in the build scripts rather than hardcoded in the CMake configuration.

Changes:
- Remove set(CMAKE_SKIP_INSTALL_RPATH TRUE) from CMakeLists.txt
- Add -DCMAKE_SKIP_RPATH=TRUE to Guix build script CONFIGFLAGS

This addresses the feedback from hebasto in https://github.com/bitcoin/bitcoin/pull/33247#discussion_r2369869582

dd5c517757

in contrib/guix/libexec/build.sh:246 in eb98b612f8

242@@ -243,6 +243,7 @@ mkdir -p "$DISTSRC"
243           --toolchain "${BASEPREFIX}/${HOST}/toolchain.cmake" \
244           -DWITH_CCACHE=OFF \
245           -Werror=dev \
246+          -DCMAKE_SKIP_INSTALL_RPATH=TRUE \

fanquake commented at 7:30 pm on September 24, 2025:

Can this just be CMAKE_SKIP_RPATH? (also move to CONFIGFLAGS)

151henry151 commented at 10:20 pm on September 24, 2025:

I think I’ve made the correct adjustments – can you check dd5c517 and let me know if this is what you had in mind?

janb84 commented at 12:27 pm on September 26, 2025:

Now that you have changed this, please update the PR description to match the recent change:

“Add -DCMAKE_SKIP_INSTALL_RPATH=TRUE to Guix build script cmake configuration” => Add -DCMAKE_SKIP_RPATH=TRUE to Guix build script cmake configuration

151henry151 force-pushed on Sep 24, 2025

DrahtBot commented at 8:55 am on September 25, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit ad4a49090da81a3683fc50694ed7b42a80fdf90b(master)	commit 62072c6c341fc5c201bf043321b9a6bcb098d125(pull/33470/merge)
*-aarch64-linux-gnu-debug.tar.gz	`05fa48653fe2429c...`	`15394eace820b521...`
*-aarch64-linux-gnu.tar.gz	`c75df3543cd982fd...`	`eb3b775f2735d4b5...`
*-arm-linux-gnueabihf-debug.tar.gz	`5ca49eaa243a8c54...`	`97363b3e6530f3c9...`
*-arm-linux-gnueabihf.tar.gz	`1a8b9b979d7aba55...`	`af3ae1b7582e9bee...`
*-arm64-apple-darwin-codesigning.tar.gz	`1fac2e0ec9121feb...`	`ac21294215fab9ba...`
*-arm64-apple-darwin-unsigned.tar.gz	`c28e65c86e3858f0...`	`9e265b832d383e11...`
*-arm64-apple-darwin-unsigned.zip	`c0029774a999291a...`	`a579603b77f16a56...`
*-powerpc64-linux-gnu-debug.tar.gz	`6388eddc9d61b821...`	`6f4d64350ecbbf43...`
*-powerpc64-linux-gnu.tar.gz	`cc3439856d396c26...`	`23077d424cfc3b85...`
*-riscv64-linux-gnu-debug.tar.gz	`83b8428d5e4973a5...`	`3647215ac7cdf752...`
*-riscv64-linux-gnu.tar.gz	`01f68cac21f07e94...`	`28c39e8cbe9a9e19...`
*-x86_64-apple-darwin-codesigning.tar.gz	`6152b1fbd13ff50e...`	`2e88d606dc52c22b...`
*-x86_64-apple-darwin-unsigned.tar.gz	`e90b611bb5d953c6...`	`614af6db2fcefe55...`
*-x86_64-apple-darwin-unsigned.zip	`41afabb5709549de...`	`3a579c6b4f8f7c46...`
*-x86_64-linux-gnu-debug.tar.gz	`ce83aa703b21c6f7...`	`793c1aadc64b203f...`
*-x86_64-linux-gnu.tar.gz	`8e4084202e42310b...`	`6011009475142175...`
*.tar.gz	`a9e97130abb5e653...`	`3afbbede33d9cc42...`
SHA256SUMS.part	`7b94502150834879...`	`2f19e35627b610b0...`
guix_build.log	`67e7c69cb5411e98...`	`4c8ae8f695b06b2f...`
guix_build.log.diff		`f363056ec5de1b15...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 25, 2025

build: Move CMAKE_SKIP_INSTALL_RPATH from CMake to Guix script #33470

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]